How to test active storage dimension validation?

Question

I have installed this gem to validate and test active storage:

gem 'active_storage_validations'

# Asset Model
class Asset < ApplicationRecord
  has_one_attached :portrait

  validates(
    :portrait,
    content_type: ['image/png', 'image/jpeg', 'image/svg+xml'],
    dimension: { width: { in: 8..512 }, height: { in: 8..512 } },
    size: { less_than: 250.kilobytes }
  )
end

# Asset test
require 'rails_helper'

RSpec.describe Asset do
  it { is_expected.to validate_dimensions_of(:portrait).width_between(8..512).height_between(8..512) }
end

However, I get this error in my test, but not out of my test:

Asset validations is expected to validate the image dimensions of :portrait
     Failure/Error: it { is_expected.to validate_dimensions_of(:portrait).width_between(8..512).height_between(8..512) }
     
     NameError:
       uninitialized constant ActiveStorageValidations::Matchers::OpenStruct

@engineersmnky You are right, thanks. I think the hanging has to do with other expectation. — Chiara Ani
– Chiara Ani, Commented Aug 21, 2024 at 12:59

engineersmnky · Accepted Answer · 2024-08-20 18:42:36Z

2

Your Issue

Your issue comes from Here.

Excerpt:

module ActiveStorageValidations
  module Matchers
    #...
    def self.mock_metadata(attachment, width, height)
      if Rails.gem_version >= Gem::Version.new('6.0.0')
        # Mock the Metadata class for rails 6
        mock = OpenStruct.new(metadata: { width: width, height: height })

The gem appears to expect OpenStruct to have been required require 'ostruct' (without actually requiring it themselves).

Add require 'ostruct' to your spec_helper.rb file and it should resolve the issue.

If so I would also open a ticket with the gem on github.

Why is this occurring?

Previous versions of the json gem required OpenStruct. Rails, or more explicitly ActiveSupport, relies on JSON (Source).

It appears that some other creators of rails gems relied on the asumption that OpenStruct was simply available (due to other gem dependencies); however, as of version 2.7.2 the json gem has made OpenStruct optional (Change Log and Pull Request).

This means that gems relying on its existence should now require it explicitly, which they probably should have from the start as require has very low overhead when a file has already been required.

answered Aug 20, 2024 at 18:42

engineersmnky

30.5k2 gold badges42 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

max Over a year ago

Ostruct is kind of soft-deprechiated and may be removed as a default gem in Ruby 3.5. bugs.ruby-lang.org/issues/20309

Collectives™ on Stack Overflow

How to test active storage dimension validation?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related