Storing instances in Laravel Service Container that may be null

Question

I'm attempting to store an instance of the current department in Laravels Service Container, however sometimes this department may be null.

The department itself is loaded from session and retrieved as such:

private function resolveCurrentDepartmentFromSession(Request $request)
{
    $departmentId = $request->session()->pull(self::CURRENT_DEPARTMENT);

    return Department::find($departmentId);
}

I store it in the Service Container by:

App::instance('Department\Current', $department);

And retrieve it as:

$department = App::bound('Department\Current') ? App::make('Department\Current') : null;

Are there no way to resolve the instance IF set, and return null otherwise? Something like App::instanceIfSet('Department\Current')? Or should I avoid storing "sometimes null" values in the Service Container? I could make a class CurrentDepartment which stores it as a property and store this in the container as a Singleton instead, but would like to know if I'm missing something essential about the Service Container first.

You might be misusing the service container, why cant you just add a helper to retrieve the department from the session? — Flame
– Flame, Commented Dec 18, 2019 at 15:41

Ohgodwhy · Accepted Answer · 2019-12-18 16:36:41Z

0

You could use the optional helper:

return optional(Department::find($departmentId));

Now when you call the bound class any property you attempt to access against it when it is null will also return null.

answered Dec 18, 2019 at 16:36

Ohgodwhy

50.9k11 gold badges86 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Storing instances in Laravel Service Container that may be null

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related