WriteFile failure when networkshare is disconnected

Question

I have a win32 app opening a log file on a network share using CreateFile and WriteFile (non overlapped) to write records. What I am seeing when the network share is lost, WriteFile reports an error (59 or 53), but an empty record (zero bytes) of the correct size is written to the file. When the share comes back online, I can see the valid data previously written and the empty records for the time that the share was lost. At the same time as the share disconnect, GetFileSize and SetFilePointer can't see any errors, but instead report the changed files as new records get added.

How does WriteFile fail when a shared file is offline ?

Happens on server 2012 ,2019, mapped drive.

Opening of the file:

hFile=CreateFile(filename,GENERIC_READ|GENERIC_WRITE,FILE_SHARE_READ|FILE_SHARE_WRITE,NULL,OPEN_EXISTING,0,NULL);
    if (hFile==INVALID_HANDLE_VALUE && GetLastError()==ERROR_FILE_NOT_FOUND)
        hFile=CreateFile(filename,GENERIC_READ|GENERIC_WRITE,FILE_SHARE_READ|FILE_SHARE_WRITE,NULL,CREATE_NEW,0,NULL);

Writing data:

if (!WriteFile(hFile,(LPCVOID)&data,sizeof(data),&bytes,NULL) || bytes==0)
{
    lasterror=GetLastError();

The file is kept open all the time.

I don't have an answer for you, just an observation - your double-call of CreateFile() introduces a TOCTOU race condition. You don't need 2 calls, just 1 call will suffice using OPEN_ALWAYS instead of OPEN_EXISTING+CREATE_NEW separately. — Remy Lebeau
– Remy Lebeau, Commented Nov 18 at 20:37

Jabberwocky · Accepted Answer · 2025-11-19 07:33:49Z

0

The empty records happen because Windows caches network writes. When the share goes offline, WriteFile fails but space is already reserved, creating zeroed records.

Fixes:

Use FILE_FLAG_WRITE_THROUGH to bypass cache:

hFile = CreateFile(filename, GENERIC_READ|GENERIC_WRITE,
                   FILE_SHARE_READ|FILE_SHARE_WRITE,
                   NULL, OPEN_EXISTING,
                   FILE_ATTRIBUTE_NORMAL | FILE_FLAG_WRITE_THROUGH, NULL);

Flush after each write:

WriteFile(hFile, &data, sizeof(data), &bytes, NULL);
FlushFileBuffers(hFile);

Handle errors and retry or queue locally.

edited Nov 19 at 7:33

Jabberwocky

51.3k18 gold badges71 silver badges127 bronze badges

answered Nov 18 at 20:42

Collectives™ on Stack Overflow

WriteFile failure when networkshare is disconnected

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related