How do I prevent code duplication when defining multiple methods with the same name?

Question

I recently discovered that you can define multiple methods with the same name as long as their arguments differ (I believe it's called method overloading). So for example, in a script I have a method called getDate(int date) and another called getDate(). The only differences between these methods is that the one that doesn't accept an argument uses a static integer defined in the class instead of the date argument.

I've used this logic for at least 5 different methods in the class, however it seems very messy to be duplicating code like this. Is there a more elegant solution?

Please show us the code you're asking about. Descriptions of code aren't that useful as they leave too much to the imagination and tend to be incomplete or inaccurate. — user47589
– user47589, Commented Apr 23, 2019 at 21:00
How about public DateTime getDate() { return getDate(staticInt); }? This would reuse the overload with the parameter by calling it, instead of copying the code. In any case, you should probably post your code so that we can see exactly what we're dealing with here, the devil is in the details and all that. — Lasse V. Karlsen
– Lasse V. Karlsen, Commented Apr 23, 2019 at 21:00
@LasseVågsætherKarlsen Man that's so simple and exactly what I need! Thanks very much. — Thomas Doyle
– Thomas Doyle, Commented Apr 23, 2019 at 21:07

William Dewayne Corrin III · Accepted Answer · 2019-04-24 19:09:13Z

3

Typically, its best to have one function that does the meat of what you're trying to achieve, while others invoke that function (or each other) to avoid duplicating actual logic.

I'll use your example:

Date GetDate(int date) {
    // -- do whatever you do here
    return DoAThing(date);
}

Date GetDate() {
    return GetDate(staticVar);
}

This way, if you want to change how you get a date, you won't have to change your code in multiple places, and when you modify GetDate(int date), your other functions that invoke it will simply follow suit.

answered Apr 24, 2019 at 19:09

William Dewayne Corrin III

762 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

William Dewayne Corrin III Over a year ago

Oops. I didn't see that @Lasse Vågsæther Karlsen basically already answered this since it was in a comment. But we are basically saying the same thing :)

Paul Atréides · Accepted Answer · 2019-04-23 21:18:39Z

-1

Just call the methods as needed e.g.

//To Get the Date normally
DateTime date = getDate();
//Otherwise
date = getDate(1, DateTime.Today);

You should not have a problem calling them. They should be overloaded correctly by unity because I checked it with my editor.

answered Apr 23, 2019 at 21:18

Paul Atréides

511 silver badge9 bronze badges

1 Comment

Draco18s no longer trusts SE Over a year ago

This is not the asker's problem.

Collectives™ on Stack Overflow

How do I prevent code duplication when defining multiple methods with the same name?

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related