php - CLI and custom commands

Question

I'm currently trying to make a php script that can be interactive with the user by executing commands. The user have to use the script in the Terminal.

here is an example about what I'm talking about:

>php robot.php
>Hello, I'm the GoodRobot number 8731039139, nice to meet you!
>Please type a command below:
>say "Hello" **// user types this**
>GoodRobot no 8731039139: Hello **// robot.php outputs this**

I want it to make it interactive as soon as init() is called but I've been trying to do what you can see below and it doesn't seem to work.

Here is my full code

<?php

class Robot 
{
    // ?? \\
}

class GoodRobot extends Robot
{
    static protected $serialNumber; 

    private $name;
    private $type = "Droid";

    public function __construct($name)
    {
        $this->name = $name;
        echo "Hello, I'm the GoodRobot number " . self::$serialNumber . ", nice to meet you!\n";
    }

    public function init()
    {
        echo "Please type a command below:" . PHP_EOL;
        $handle = fopen ("php://stdin","r");
        $line = fgets($handle);
        if(trim($line) != 'say')
        {
            print(say($str));
        }
        elseif (trim($line) != 'help') {
            print(help());
        }
        else
        {
            echo "ERROR: Unknown command. Type \"help\" if you need help." . PHP_EOL;
        }
    }

    public function setName($name) 
    {
        $this->name = $name;
    }

    public function getName($name)
    {
        return $this->name;
    }

    public function help()
    {
        echo "Here is a list of commands: \n - say \"something\" \n - shutDown \n";
    }

    public function say($str)
    {
        echo "GoodRobot no " . self::$serialNumber . " : " . $str . "\n";
    }

    public function turnOn()
    {
        echo "Waking up... Please be patient.\n";
        parent::__construct();
    }

    public function shutDown()
    {
        echo "Shutting down...\n";
        exit;
    }
}

$hi = new GoodRobot("hi");
$hi -> init();

When I'm trying to "say"

It display a fatal error

PHP Fatal error: Uncaught Error: Call to undefined function say()

what IS happening?

delboy1978uk
– delboy1978uk

2018-05-04 15:01:10 +00:00
Commented May 4, 2018 at 15:01 — delboy1978uk
– delboy1978uk, Commented May 4, 2018 at 15:01
somehow your function say is executing?

coder
– coder

2018-05-04 15:04:43 +00:00
Commented May 4, 2018 at 15:04 — coder
– coder, Commented May 4, 2018 at 15:04
@coder I edited my code to be more clear

Margaret Osborn
– Margaret Osborn

2018-05-04 15:06:27 +00:00
Commented May 4, 2018 at 15:06 — Margaret Osborn
– Margaret Osborn, Commented May 4, 2018 at 15:06
its working then. but it should be $this->say($whatever)

delboy1978uk
– delboy1978uk

2018-05-04 15:07:03 +00:00
Commented May 4, 2018 at 15:07 — delboy1978uk
– delboy1978uk, Commented May 4, 2018 at 15:07
you don't define $str. did you mean $line?

delboy1978uk
– delboy1978uk

2018-05-04 15:09:27 +00:00
Commented May 4, 2018 at 15:09 — delboy1978uk
– delboy1978uk, Commented May 4, 2018 at 15:09

Nigel Ren · Accepted Answer · 2018-05-04 16:02:36Z

1

You need to use $this-> when referring to a method in the current class. I've also changed your input to just readline() as this handles the IO.

Also note the string manipulation to change the say "Hello" to remove the first bit and any surrounding quotes.

public function init()
{
    echo "Please type a command below:" . PHP_EOL;
    $line = readline();
    if(substr($line, 0, 3) == 'say')
    {
        $line = substr($line, 3);
        $line = rtrim(trim($line,"\" "),"\" \n\r");
        $this->say($line);
    }
    elseif (substr($line, 0, 4) == 'help') {
        $this->help();
    }
    else
    {
        echo "ERROR: Unknown command. Type \"help\" if you need help." . PHP_EOL;
    }
}

I'm not sure why you had print() around the say() call, say() echos out the string, so the print is not needed.

You also need to check the first 3 chars are 'say' rather than using trim(). Same for 'help' (although 4 chars this time).

Update: When testing add..

ini_set('display_errors', 'On');
error_reporting(E_ALL);

to the top of your script, it helps in showing any errors in the code.

edited May 4, 2018 at 16:02

answered May 4, 2018 at 15:33

Nigel Ren

57.2k11 gold badges49 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Margaret Osborn Over a year ago

It outputs a "e" whatever I do, weird

Margaret Osborn Over a year ago

say "something" doesn't do anything it just displays the say function without any string and just blank space

Margaret Osborn Over a year ago

just typing say displays an e

Nigel Ren Over a year ago

OK - can't replicate that. I'm assuming you've made no changes to any of the other code in your original question.

Nigel Ren Over a year ago

Also - worth adding the lines I've added to the answer - they show any errors in your code when testing.

Collectives™ on Stack Overflow

php - CLI and custom commands

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related