creating list of custom object in mvc2 controller

Question

Model::::

 public class Model1

    {

        public string Name { get; set; }

        public string ProductName { get; set; }

    }

ViewModel::::

public class ViewModel1

    {

      public  List<Model1> model1;

    }

controller:::::::::

var sent = entities.Table1.Where<Table1>(o => o.SenderUserId == userId );

          ViewModel1 newViewModel = new ViewModel1();

            foreach (Table1 gf in sent)

            {

                var nmodel = new Model1();

                nmodel.Name = gf.Name;

                nmodel.ProductName = doSomething(gf.ProductName);

               // **Here I'm stuck====how do I add nmodel to newViewModel**

               //**newViewModel.Add===does not work**

            }

          return View(newViewModel);

Are you getting a null reference exception? Can you be more clear about "does not work"? — Brook
– Brook, Commented Jan 3, 2011 at 5:04
I do not get 'Add' as the viewModel does not have an add method. — Arnab
– Arnab, Commented Jan 3, 2011 at 5:10

Brook · Accepted Answer · 2011-01-03 05:10:49Z

1

A quick guess based on the code you posted, is that you never instantiated the collection.

public class ViewModel1
{
    List<Model1> model1;
    public ViewModel1()
    {
        model1=new List<Model1>();
    }
}
......
newViewModel.model1.Add(nmodel);

edited Jan 3, 2011 at 5:10

answered Jan 3, 2011 at 5:05

Brook

6,0293 gold badges33 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Arnab Over a year ago

Sorry, I changed the code, its actually public List<Model1> model1;

Brook Over a year ago

Yes, I see that it's public, You still need to instantiate it somewhere before you can call Add. I added the correct syntax to add to it.

Arnab Over a year ago

Thanks a lot, I have a feeling this will work, just another thing: var sent = entities.Table1.Where<Table1>(o => o.SenderUserId == userId ) will sometimes give me null values.

Arnab Over a year ago

y, I know, should i ask it in a diff question, thisis the first time I'm using stackoverflow

Brook Over a year ago

Yes that makes the most sense to me in this instance. However, if it SHOULD ALWAYS return something, then a better practice might be to throw an exception.

Chandu · Accepted Answer · 2011-01-03 05:38:44Z

1

Change your ViewModel as follows ViewModel::::

public class ViewModel1
{
    public  List<Model1> model1 = new List<Model1>();
}

Change your controller as follows:

var sent = entities.Table1.Where<Table1>(o => o.SenderUserId == userId );
ViewModel1 newViewModel = new ViewModel1();
foreach (Table1 gf in sent)
{
        var nmodel = new Model1();
        nmodel.Name = gf.Name;
        nmodel.ProductName = doSomething(gf.ProductName);
        newViewModel.model1.Add(nmodel);
}

return View(newViewModel);

edited Jan 3, 2011 at 5:38

answered Jan 3, 2011 at 5:15

Chandu

83.2k19 gold badges136 silver badges136 bronze badges

1 Comment

Arnab Over a year ago

y, that is what brook said, though ur answer will be more clear to new people, just add '()'in the viewmodel, thanks for your reply

Collectives™ on Stack Overflow

creating list of custom object in mvc2 controller

2 Answers 2

5 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related