Last Value Null in PHP, but Jquery Picking up Last Row from Table

Question

I am trying to pass variables to jquery for ajax from html/php.

This is the html/php:

<?php
    $propertyid = $data['property_id'];
    $select5 = $con->prepare("SELECT favorite_properties_id, favorite_properties_property_id FROM tbl_favorite_properties where favorite_properties_user_id = '".$_SESSION['user_id']."' AND favorite_properties_property_id='$propertyid;'");
    $select5->setFetchMode(PDO::FETCH_ASSOC);
    $select5->execute();

    while($data5=$select5->fetch()){
        echo $data5['favorite_properties_id'];
        $favorite_properties_id = $data5['favorite_properties_id'];
    }
?>

<a href="#">
    <img class="addtofavoritebutton" pid="<?php echo $propertyid; ?>" fpid="<?php echo $favorite_properties_id;?>" src="../images/system/addtofavorite.png">
</a>
<?php echo $data['property_id']; ?>

This is the jquery:

$('.addtofavoritebutton').click(function() {    
    var property_id = $(this).attr('pid');
    var favorite_properties_id = $(this).attr('fpid');

    alert(property_id);
    alert(favorite_properties_id);      
});

There are two rows in the tbl_favorite_properties, table however jquery is picking up the last row for fpid, even when there is no data. When I echo in php then the value is blank (as it should be) but in jquery it is taking the last row and repeating the value, when it can't find. How can I get jquery to pick up the blank or null value just like php?

echo $data5['favorite_properties_id']; is giving the right value - in php but var favorite_properties_id = $(this).attr('fpid'); in jquery is repeating the last value when it should also pick up blank value. — DragonFire
– DragonFire, Commented Jan 30, 2017 at 9:49
your code is vulnerable to sql injection. use prepared statments as they are intended to use instead and consider the following lecture: laurent22.github.io/so-injections — Joshua
– Joshua, Commented Jan 30, 2017 at 9:58
@Joshua - do I need to even prepare the select statements, or only the insert, update and delete statements — DragonFire
– DragonFire, Commented Jan 30, 2017 at 10:12
you should prepare all statements and use the bindParam methods of PDOStatement to set values on the queries. A good read is this question: stackoverflow.com/questions/15758185/… You should consider reading the linked question there too — Joshua
– Joshua, Commented Jan 30, 2017 at 10:17

Furqan Aziz · Accepted Answer · 2017-01-30 10:05:25Z

0

Actually you are using $favorite_properties_id after finishing the while loop and variable $favorite_properties_id will contain the value of the last iteration of while loop.

<?php
    $propertyid = $data['property_id'];
    $select5 = $con->prepare("SELECT favorite_properties_id, favorite_properties_property_id FROM tbl_favorite_properties where favorite_properties_user_id = '".$_SESSION['user_id']."' AND favorite_properties_property_id='$propertyid;'");
    $select5->setFetchMode(PDO::FETCH_ASSOC);
    $select5->execute();

    $favorite_properties_id = null;
    while($data5=$select5->fetch()){
        echo $data5['favorite_properties_id'];
        $favorite_properties_id = $data5['favorite_properties_id'];
    }
    ?>

    <a href="#"><img class="addtofavoritebutton" pid="<?php echo $propertyid; ?>" fpid="<?php echo $favorite_properties_id;?>" src="../images/system/addtofavorite.png"></a>

    <?php echo $data['property_id']; ?>

edited Jan 30, 2017 at 10:05

answered Jan 30, 2017 at 9:59

Furqan Aziz

1,1149 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

DragonFire Over a year ago

If i do that then the image disappears

Furqan Aziz Over a year ago

I have edited code, You can check it now please. I think you need to reset $favorite_properties_id = null; before loop

DragonFire · Accepted Answer · 2017-01-30 10:09:26Z

0

<?php
                $propertyid = $data['property_id'];
                $select5 = $con->prepare("SELECT favorite_properties_id, favorite_properties_property_id FROM tbl_favorite_properties where favorite_properties_user_id = '".$_SESSION['user_id']."' AND favorite_properties_property_id='$propertyid;'");
                $select5->setFetchMode(PDO::FETCH_ASSOC);
                $select5->execute();
                ?>

                <a href="#"><img class="addtofavoritebutton" pid="<?php echo $propertyid; ?>" fpid="<?php while($data5=$select5->fetch()){echo $data5['favorite_properties_id'];} ?>" src="../images/system/addtofavorite.png"></a>

This is working now.

answered Jan 30, 2017 at 10:09

DragonFire

4,1222 gold badges41 silver badges59 bronze badges

1 Comment

DragonFire Over a year ago

It was the problem with loop only, thanks guys for pointing it out.

Kaushik solanki · Accepted Answer · 2017-01-30 10:11:26Z

0

PLease put your tag inside loop

<?php
$propertyid = $data['property_id'];
$select5 = $con->prepare("SELECT favorite_properties_id, favorite_properties_property_id FROM tbl_favorite_properties where favorite_properties_user_id = '".$_SESSION['user_id']."' AND favorite_properties_property_id='$propertyid;'");
$select5->setFetchMode(PDO::FETCH_ASSOC);
$select5->execute();

while($data5=$select5->fetch()) {
    echo $data5['favorite_properties_id'];
    $favorite_properties_id = $data5['favorite_properties_id'];
    echo '<a href="#"><img class="addtofavoritebutton" pid="'.$propertyid.'" fpid="'.$favorite_properties_id.'" src="../images/system/addtofavorite.png"></a>';
}
?>
<?php echo $data['property_id']; ?>

edited Jan 30, 2017 at 10:11

answered Jan 30, 2017 at 9:57

Kaushik solanki

4381 gold badge3 silver badges15 bronze badges

2 Comments

DragonFire Over a year ago

If i do that then the image disappears

Kaushik solanki Over a year ago

can u please explain what exactly you want?

Collectives™ on Stack Overflow

Last Value Null in PHP, but Jquery Picking up Last Row from Table

3 Answers 3

2 Comments

1 Comment

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related