External javascript not working?

Question

I just started learning javascript about 30 minutes ago. I'm doing an online course and they gave me this code as an example. The person in the video did the exact same thing, but it only works for me when I do inline not external. My .js name is right and they're in the same folder.

The html:

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="utf-8">
  <title>JavaScript Basics</title>    
  <script src=“cripts.js”></script>
 </head>
<body>
  <div class="container">
  <h1>Where to place your JavaScript code.</h1>
  </div>
</body>
</html>

and the js:

alert("YOU");

Nothing appears for me. I've tried everything to make it work, including different browsers. Could it be my computer or did I make a simple mistake?

Those are funny quote characters in the <sctipt tag line. I believe you copied it from somewhere, and as a beginner it would be helpful if you type manually instead. — zerkms
– zerkms, Commented Aug 29, 2016 at 0:42

James111 · Accepted Answer · 2016-08-29 00:51:55Z

2

It looks like your quotes are invalid :') Good beginner move! But it will be a simple fix. Note the “ should be ", this usually happens when copying and pasting code!

<script src="cripts.js"></script>

Also make sure your path and file name is correct?! cripts.js sounds like it is suppose to be scripts.js

answered Aug 29, 2016 at 0:51

James111

16k17 gold badges88 silver badges130 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Bergi Over a year ago

I rarely see this as a result of c&p, rather of using the wrong editor. Or: not using a code editor but a word processor.

James111 Over a year ago

Either way, they are invalid :D @Bergi - Maybe it's time for the OP to change editors :“)

Sebastian Simon Over a year ago

It often happens in TextEdit on iOS.

melkadri Over a year ago

Yeah, I wrote the command in my notes on pages on mac and then copied it. Can't believe I spent all that time for just that. Thank YOU.

James111 Over a year ago

Haha! It happens to the best of us @melkadri

A Gawthrop · Accepted Answer · 2018-01-10 21:08:59Z

0

A beginner mistake I made was to use <script>...</script> tags in the external javascript file. From HTML if you use:

<script type="text/javascript" src="../myApp/myFile.js"></script>

Then the external js file should just contain just the code such as:

function myFunction {}

with no script tags. This is unlike linking to external css files which include the <style>...</style> tags.

answered Jan 10, 2018 at 21:08

A Gawthrop

11 bronze badge

Collectives™ on Stack Overflow

External javascript not working?

2 Answers 2

5 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related