Synchronize Properties in Swift 3 using GCD

Question

I watched this years WWDC GCD talk lately and I think there is a code snippet something is wrong with. It is about making a property thread-safe using DispatchQueues.

class MyObject {
    private var internalState: Int
    private let internalQueue: DispatchQueue // Serial or Concurrent?

    var state: Int {
        get {
            return internalQueue.sync { internalState }
        }

        set (newState) {
            internalQueue.sync { internalState = newState }
        }
    }
}

They use a DispatchQueue to lock a property. But i think this snippet is not valid, because the internalQueue could be concurrent. So if we call the setter from two different DispatchQueues/Threads if that internal queue is not serial, it could also lead to threading problems right? Because in my understanding sync just holds the invoking thread and continues if the task is complete. What do you think about this snippet? Am I wrong?

Yes, you would define internalQueue as a serial dispatch queue. — Martin R
– Martin R, Commented Jul 14, 2016 at 11:49

Abdulrahman Alsoghayer · Accepted Answer · 2020-08-16 20:41:08Z

24

I'd like just to show another approach that makes you able to read concurrently, but block everything while writing by using a dispatch barrier.

class MyObject {
private var internalState: Int
private let internalQueue = DispatchQueue(label: "reader-writer", attributes: .concurrent)

var state: Int {
    get {
        return internalQueue.sync { internalState }
    }

    set (newState) {
        internalQueue.async(flags: .barrier) { internalState = newState }
    }
  }
}

With that approach, reads can occur concurrently on the queue, but writes are executed exclusively, due to the barrier.

This is just a Swift 3 conversion of an approach explained in the book Effective Objective C 2.0, written by Matt Galloway.

edited Aug 16, 2020 at 20:41

Abdulrahman Alsoghayer

16.6k7 gold badges53 silver badges57 bronze badges

answered Feb 13, 2017 at 13:02

Andrea

26.4k10 gold badges91 silver badges137 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

jscs Over a year ago

Nice. Could also use a private concurrent queue here.

Paulo Mattos Over a year ago

This question provides more context on the .barrier option.

matt · Accepted Answer · 2016-07-14 11:55:16Z

13

But i think this snippet is not valid, because the internalQueue could be concurrent

But it isn't concurrent. Dispatch queues that you create are serial by default. That is the point of the technique (and the example).

answered Jul 14, 2016 at 11:55

matt

540k97 gold badges943 silver badges1.3k bronze badges

2 Comments

matt Over a year ago

You might want to watch WWDC videos on GCD from earlier years. They are clearer on this point.

Sebastian Boldt Over a year ago

Thanks Matt,I didn't know that.

Collectives™ on Stack Overflow

Synchronize Properties in Swift 3 using GCD

2 Answers 2

2 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related