Adding Constraints for Nullable Enum

Question

I'm writing some Enum functionality, and have the following:

public static T ConvertStringToEnumValue<T>(string valueToConvert, bool isCaseSensitive)
{
    if (typeof(T).BaseType.FullName != "System.Enum" && typeof(T).BaseType.FullName != "System.ValueType")
    {
       throw new ArgumentException("Type must be of Enum and not " + typeof (T).BaseType.FullName);
    }

    if (String.IsNullOrWhiteSpace(valueToConvert))
      return (T)typeof(T).TypeInitializer.Invoke(null);

    valueToConvert = valueToConvert.Replace(" ", "");              

    if (typeof(T).BaseType.FullName == "System.ValueType")
    {
        return (T)Enum.Parse(Nullable.GetUnderlyingType(typeof(T)), valueToConvert, !isCaseSensitive);
    }

    return (T)Enum.Parse(typeof(T), valueToConvert, !isCaseSensitive);
}

I call it like this:

EnumHelper.ConvertStringToEnumValue<Enums.Animals?>("Cat");

I now want to add constraints to T to an Enum, such as (which I got from Stackoverflow article): where T : struct, IConvertible but I am having problems as T needs to be able to take nullable enums. Error message says:

The type 'Enums.Animals?' must be a non-nullable value type in order to use it as parameter 'T' in the generic type or method

Is there a way to do this, or do I need to just rely on the runtime checking which I have inside the method?

Thanks all!

DO NOT DUPLICATE YOUR QUESTIONS!!! As it stands, your code is bogus. Please refer to your previous question, why I say that. — leppie
– leppie, Commented Sep 28, 2010 at 8:44
@leppie: Although the current code is bogus, the constraint part isn't - and it's a separate question. — Jon Skeet
– Jon Skeet, Commented Sep 28, 2010 at 8:46
@Jon Skeet: I believe firmly in sorting out one problem at a time. The way the OP is going, he will just get confused, and ultimately waste all of the time of the people trying to assist him. — leppie
– leppie, Commented Sep 28, 2010 at 8:49
@leppie: I suspect that if the OP goes forward with the suggestion in my answer, his code will actually become a lot simpler anyway - so the first problem will either go away or at least be easier to solve. — Jon Skeet
– Jon Skeet, Commented Sep 28, 2010 at 8:53
@leppie: It's 2 different questions. There's no rule that says you can't ask more than one question at a time, in fact, it's encouraged. If you think he's wasting your time I suggest you simply ignore the question. — Jaco Pretorius
– Jaco Pretorius, Commented Sep 28, 2010 at 9:12

Jon Skeet · Accepted Answer · 2010-09-28 08:48:18Z

9

No, there's no constraint which says "T must be a value type, including nullable value types."

One option, however, would be to split the method into to:

public static T ConvertStringToEnumValue<T>(...) where T : struct
public static T? ConvertStringToNullableEnumValue<T>(...) where T : struct

Aside from anything else, each method's implementation would then be simpler, too.

Of course, we don't know how you're going to use this code - but if you're going to call it directly from non-generic methods, this would be my suggested approach.

Of course, that's still not going to stop someone from calling it with T=int or something like that... you might want to look at Unconstrained Melody for more rigid constraints.

answered Sep 28, 2010 at 8:48

Jon Skeet

1.5m893 gold badges9.3k silver badges9.3k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Bear Monkey · Accepted Answer · 2010-09-28 10:15:35Z

1

There is a trick that involves C++/CLI which does allow generic constraints on Enums. Write a base abstract class in C++/CLI with the Enum constraint. Reference the library in a C# project and implement the base class.

edited Sep 28, 2010 at 10:15

answered Sep 28, 2010 at 10:02

Bear Monkey

5212 silver badges9 bronze badges

Collectives™ on Stack Overflow

Adding Constraints for Nullable Enum

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related