RecyclerView - Where should I handle its click events?

Question

Prior to the introduction of RecyclerView (and its mandatory ViewHolder pattern), I usually delegate any click events to its corresponding Activity/Fragment using setOnItemClickListener(). (Because I mainly see Activity/Fragment as a "controller" object when developing for Android, thus any modification to the view should be done in it.)

Now, as RecyclerView doesn't really treat its children the same way and that setOnItemClickListener() (or similar) methods are no longer implemented for it - where should I handle click events that may take place? I don't know.. but handling them in an Adapter seems awkward to me.

How are we supposed to do it?

Thanks in advance!

make your custom ViewHolder implement OnClickListener

pskink
– pskink

2014-12-24 07:58:02 +00:00
Commented Dec 24, 2014 at 7:58 — pskink
– pskink, Commented Dec 24, 2014 at 7:58

DSS · Accepted Answer · 2014-12-24 10:39:13Z

5

Create your own viewHolder for the recycler view as we always do it, and in the onBindView method, set the click listener to the view you wish to perform the click.

@Override
public void onBindViewHolder(final ViewHolder viewHolder, int position) {
viewHolder.mRelContent.setOnClickListener(new OnClickListener() {
        @Override
        public void onClick(View v) {
            // perform ur click here
        }
    });
}

answered Dec 24, 2014 at 10:39

DSS

7,2995 gold badges33 silver badges42 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Hadi Satrio Over a year ago

I ended up using your method. Volodymyr's answer is great for lists that do not need to handle long press events, otherwise one would need to do some serious tweaking to make it work. Yours is much more easier to implement. Thanks!

user1443317 Over a year ago

This is a simple solution however if you would like to reuse this ViewHolder elsewhere in your code and provide different click/touch handlers, then this approach is not suitable. You will need to handle the events outside the adapter (or ViewHolder).

Azlan Jamal Over a year ago

I thinks best way to handle this is inside activity or fragment

Community · Accepted Answer · 2017-05-23 10:27:31Z

4

See Jacob's implementation of RecyclerView.OnItemTouchListener. I think it's the best solution.

Hope it will help you. Regards.

edited May 23, 2017 at 10:27

CommunityBot

11 silver badge

answered Dec 24, 2014 at 10:47

Volodymyr Yatsykiv

3,2111 gold badge26 silver badges29 bronze badges

2 Comments

veritas Over a year ago

why do you think this method is better than the one OP accepted as answer?

Volodymyr Yatsykiv Over a year ago

@veritas because in accepted answer you have to set click listener every time when you bind view holder, in this case you set touch listener for RecyclerView in one place and that's it. Like on ListView.

Collectives™ on Stack Overflow

RecyclerView - Where should I handle its click events?

2 Answers 2

3 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related