java - Managing duplicate code in multiple catch blocks [duplicate]

Question

I have the following code

    try {
        // code
    } catch (Exception1 e1) {
        if (condition) {
            //code
        } else {
            throw e1;
        }
    } catch (Exception2 e2) {
        if (condition) {
            //code
        } else {
            throw e2;
        }
    }

How can I use a private method to modularize the if-else block in both the catches.

More specifically, if i use a method how to pass the different exceptions to the method and throw them appropriately?

I followed this link, but did not understand how to pass and throw the right exceptions.

I have seen handling multiple exceptions in same catch. But I just want to use a method to replace the if-else block — Sairam Sankaran
– Sairam Sankaran, Commented May 28, 2013 at 22:19

DannyMo · Accepted Answer · 2013-05-28 22:18:57Z

7

If working with Java 7, you can use the new pipe syntax:

catch (Exception1|Exception2 e)
{
  if(condition) {
    //code
  } else {
    throw e;
  }
}

answered May 28, 2013 at 22:18

DannyMo

12.1k4 gold badges34 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Daniel Kaplan Over a year ago

That's awesome. I didn't know of that feature. Where can I get a concise list of all the new Java 7 language changes?

DannyMo Over a year ago

@tieTYT try: oracle.com/technetwork/java/javase/…

Ankit · Accepted Answer · 2013-05-28 22:18:06Z

2

there are various ways, one simple way could be to define a method as:

private void method(Exception e){
if (condition) {
            //code
        } else {
            throw e1;
        }
}

then call it in your catch

try {
        // code
    } catch (Exception1 e1) {
        method(e1);
    } catch (Exception2 e2) {
        method(e2);
    }

answered May 28, 2013 at 22:18

Ankit

6,6226 gold badges51 silver badges72 bronze badges

Comments

Daniel Kaplan · Accepted Answer · 2013-05-28 22:18:33Z

2

This is as simple as putting the if/else in a method.

try {
    // code
} catch (Exception1 e1) {
    logic(e1);
} catch (Exception2 e2) {
    logic(e2);
}


private void logic(Exception e) throws Exception {
    if (condition) {
        //code
    } else {
        throw e;
    }
}

answered May 28, 2013 at 22:18

Daniel Kaplan

68.4k60 gold badges273 silver badges413 bronze badges

7 Comments

Sairam Sankaran Over a year ago

So I need not worry about downcasting the exceptions?

Konstantin Yovkov Over a year ago

What if Exception2 extends Exception1 ? :)

Daniel Kaplan Over a year ago

@SairamSankaran No, Exception is the parent of all Exceptions. You don't need to cast.

Daniel Kaplan Over a year ago

@kocko what problem would that cause?

Konstantin Yovkov Over a year ago

Well, if you handle two exceptions in a try/catch block, which are (lets say) father and son, you have to define the catch block in specific order - the first catch should be for the child, the next one should be for the father. Otherwise you won't be able to compile your code, as far as I remember. :)

|

Hamed Moghaddam · Accepted Answer · 2013-05-28 22:20:25Z

0

The only thing you want to make sure to do in the answers people post is you need to put the Exception1 must not be superclass of Exception2 otherwise does not compile. Java 7 answer below is the best way to handle it and order matters as I explained

For list of changes in Java 7

http://www.oracle.com/technetwork/java/javase/jdk7-relnotes-418459.html

answered May 28, 2013 at 22:20

Hamed Moghaddam

5593 silver badges8 bronze badges

Collectives™ on Stack Overflow

java - Managing duplicate code in multiple catch blocks [duplicate]

4 Answers 4

2 Comments

Comments

7 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

7 Comments

Comments

Linked

Related