Java - Load file, replace string, save

Question

I have a program that loads lines from a user file, then selects the last part of the String (which would be an int)

Here's the style it's saved in:

nameOfValue = 0
nameOfValue2 = 0

and so on. I have selected the value for sure - I debugged it by printing. I just can't seem to save it back in.

if(nameOfValue.equals(type)) {
        System.out.println(nameOfValue+" equals "+type);
            value.replace(value, Integer.toString(Integer.parseInt(value)+1));
        }

How would I resave it? I've tried bufferedwriter but it just erases everything in the file.

Any reason you're not just using Properties? In any case, unless you do some irritating random access stuff, you need to write all the properties back out. See stuff like this. — Dave Newton
– Dave Newton, Commented Nov 7, 2011 at 2:42

Óscar López · Accepted Answer · 2011-11-07 03:12:56Z

5

My suggestion is, save all the contents of the original file (either in memory or in a temporary file; I'll do it in memory) and then write it again, including the modifications. I believe this would work:

public static void replaceSelected(File file, String type) throws IOException {

    // we need to store all the lines
    List<String> lines = new ArrayList<String>();

    // first, read the file and store the changes
    BufferedReader in = new BufferedReader(new FileReader(file));
    String line = in.readLine();
    while (line != null) {
        if (line.startsWith(type)) {
            String sValue = line.substring(line.indexOf('=')+1).trim();
            int nValue = Integer.parseInt(sValue);
            line = type + " = " + (nValue+1);
        }
        lines.add(line);
        line = in.readLine();
    }
    in.close();

    // now, write the file again with the changes
    PrintWriter out = new PrintWriter(file);
    for (String l : lines)
        out.println(l);
    out.close();

}

And you'd call the method like this, providing the File you want to modify and the name of the value you want to select:

replaceSelected(new File("test.txt"), "nameOfValue2");

edited Nov 7, 2011 at 3:12

answered Nov 7, 2011 at 3:04

Óscar López

237k38 gold badges321 silver badges391 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user1032232 Over a year ago

Thanks, this helped alot. I was thinking about loading into a seperate file, then deleting the original, but using memory would be a much better idea in my case.

Upul Bandara · Accepted Answer · 2011-11-07 03:02:59Z

1

I think most convenient way is:

Read text file line by line using BufferedReader
For each line find the int part using regular expression and replace it with your new value.
Create a new file with the newly created text lines.
Delete source file and rename your new created file.

Please let me know if you need the Java program implemented above algorithm.

answered Nov 7, 2011 at 3:02

Upul Bandara

6,0134 gold badges41 silver badges60 bronze badges

Comments

Newtopian · Accepted Answer · 2011-11-07 03:03:57Z

0

Hard to answer without the complete code...

Is value a string ? If so the replace will create a new string but you are not saving this string anywhere. Remember Strings in Java are immutable.

You say you use a BufferedWriter, did you flush and close it ? This is often a cause of values mysteriously disappearing when they should be there. This exactly why Java has a finally keyword.

Also difficult to answer without more details on your problem, what exactly are you trying to acheive ? There may be simpler ways to do this that are already there.

answered Nov 7, 2011 at 3:03

Newtopian

7,7524 gold badges52 silver badges73 bronze badges

Collectives™ on Stack Overflow

Java - Load file, replace string, save

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related