can not update data using select statement for where condition

Question

I am trying to update data with where condition. I am trying to get the where condition of update statement from the select statement. But in this case the data is not updated.

public function update(string $id, Request $request)
{
    
        $select_id = Finish::select('id')->where('id', $id)->distinct()->first();

        return ($select_id);   //  response === {"id":36}
        
        // this can update data
        Finish::where('id', $id)->update([
            'remarks1' => $request->formData['remarks1']
        ]);
        
        // this can't update data, why???
        Finish::where('id', $select_id)->update([
            'remarks1' => $request->formData['remarks1']
        ]);
        
        return response()->json(['status' => '200']);
    
}

Why is it so?

did you read the docs or check the return type of ->first(). This returns a model or null, it does not return a value. You could do this with ->value('id') tho — kris gjika
– kris gjika, Commented Sep 19 at 16:06
What is the point of this function? You get the id passed in un-validated input then load the id of the database record identified by the id ???? — Snapey
– Snapey, Commented Oct 2 at 21:55

Sudam Ranasinghe · Accepted Answer · 2025-09-20 07:40:26Z

1

issue is the selected_id variable is an object.

$select_id = Finish::select('id')->where('id', $id)->distinct()->first();

this will return something like this

{"id":36}

So you have to input in the array only the value to the where function.

you could have done it like this

 $select_id = Finish::select('id')->where('id', $id)->distinct()->first();

// Access the property:
Finish::where('id', $select_id->id)->update([
    'remarks1' => $request->formData['remarks1']
]);

answered Sep 20 at 7:40

Sudam Ranasinghe

281 silver badge8 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

can not update data using select statement for where condition

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related