Temporarily replace values in string

Question

I have a very simple question for you, but I cannot find it on the internet. I have a list called ArrayList(i) of which I want to replace some strings for only one line. After that line, it should be changed back again. It works, but I want to learn how to do this more efficiently. I presume I need a loop only for the "fileName" line, but I'm not sure. The length of ArrayList is different everytime, and does not always contain the strings to be replaced, only somtimes.

    'REPLACE NAME
    ArrayList(i) = Replace(ArrayList(i), "NameOld1", "NameNew1")
    ArrayList(i) = Replace(ArrayList(i), "NameOld2", "NameNew2")
    
    finalName = PathCut & "XT\" & NumPart(initName) & "_" & partcode & " " & ArrayList(i) & " " & CodeNR & ExtNew

    'REPLACE NAME BACK
    ArrayList(i) = Replace(ArrayList(i), "NameNew1", "NameOld1")
    ArrayList(i) = Replace(ArrayList(i), "NameNew2", "NameOld2")

    swApp.CloseDoc ArrayList(i) & ".SLDPRT" 'Close the files

I am sure there must be an easier and cleaner way. Thank you in advance!

How about using a temporary string and not replacing in the array itself? This sting you could use the creation of the filename. — Shrotter
– Shrotter, Commented Aug 26, 2024 at 10:07
What is NumPart? When you say having a list, do you mean an array? If not sure, how does your code load it? If an array, you can replace at once, using the joined array. Something like Dim strArr as String strArr=join(ArrayList, "|") then ArrayList = split(Replace(Replace(strArr, "NameOld1", "NameNew1"), "NameOld2", "NameNew2"), "|"). Now you have the array with replaced strings. You can use a different array for that (arrRepl = ...). If the string to be replaced does not exist, nothing wrong happens. — FaneDuru
– FaneDuru, Commented Aug 26, 2024 at 10:51

taller · Accepted Answer · 2024-08-26 19:17:53Z

1

Introduce a new variable newStr and use nested Replace function, then you don't have to revert it with last two replacement.

    Dim newStr As String
    newStr = Replace(Replace(ArrayList(i), "NameOld1", "NameNew1"), "NameOld2", "NameNew2")
    
    finalName = PathCut & "XT\" & NumPart(initName) & "_" & partcode & " " & newStr & " " & CodeNR & ExtNew

    swApp.CloseDoc ArrayList(i) & ".SLDPRT" 'Close the files

answered Aug 26, 2024 at 19:17

taller

19.7k2 gold badges9 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Temporarily replace values in string

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related