Refactoring methods that use the same code but different input params

Question

I have these two methods. Can someone help me to refactor and make them common?

public void method1(Map<String,String> map, String key, String value){
  map.put(key, value);
}

public void method2(GenericRecord recordMap, String key, String value){
  recordMap.put(key, value);
}

Unable to refactor it.

Make GenericRecord implement Map. Otherwise, you can't. Java has no duck typing. — Michael
– Michael, Commented Dec 7, 2022 at 16:13
@Michael not entirely true. We could define an interface KeyValueConsumer<K, V> with a method void consume(K key, V value) and then require a KeyValueConsumer<String, String>as parameter, that can be passed along as a lambda. — Turing85
– Turing85, Commented Dec 7, 2022 at 16:15
@Turing85 And in the context of this contrived example, you just invented a method that does almost nothing. The one single thing these methods do is call put, and you just shifted that responsibility to the caller. — Michael
– Michael, Commented Dec 7, 2022 at 16:20
@Michael depending on the content of the actual method, it centralizes the implementation. — Turing85
– Turing85, Commented Dec 7, 2022 at 16:23
@Turing85 It's not worth speculating about that. We simply don't know. — Michael
– Michael, Commented Dec 7, 2022 at 16:26

Turing85 · Accepted Answer · 2022-12-08 12:05:43Z

-1

One possibility would be to use the BiConsumer interface. We can use this interface to implement the put-logic we need:

static <K, V> void add(BiConsumer<K, V> consumer, K key, V value) {
  consumer.accept(key, value);
}

and call it like this:

add(map::put, key, value);
add(record::put, key, value);

If we want, we can define overloaded convenience-methods:

static <K, V> void add(Map<K, V> map, K key, V value) {
  add(map::put, key, value);
}

static <K, V> void add(GenericRecord<K, V> record, K key, V value) {
  add(record::put, key, value);
}

and just call the methods as we do now.

Ideone demo

edited Dec 8, 2022 at 12:05

answered Dec 7, 2022 at 16:28

Turing85

20.3k7 gold badges41 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Refactoring methods that use the same code but different input params

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related