ASP.NET MVC3: upload image and save it to database

Question

I am working on Steven Sanderson's book (Pro ASP.NET MVC 3). I am on p. 294. I've copied word per word what's in the book but it is not working.

This is the action method

public ActionResult Edit(Product product, HttpPostedFileBase image)
{
  if(ModelState.IsValid)
  {
    if(image != null)
    {
      product.ImageMimeType = image.ContentType;
      product.ImageData = new byte[image.ContentLength];
      image.InputStream.Read(product.ImageData, 0, image.ContentLength); 
    }

    //...Save product in the database using Entity Framework
  }
}

This is how to display the image on the razor page

<img width="150" height="150"
  src = "@Url.Action("GetImage", "Home", new { Model.ProductID })" />

And finally, the GetImage

public FileContentResult GetImage(int productID)
    {
        Product prod = repository.Products.FirstOrDefault(p => p.ProductID == productID);
        if (prod != null)
        {
            return File(prod.ImageData, prod.ImageMimeType);
        }
        else
        {
            return null;
        }
    }

EDIT

I have followed the whole process (while debugging) from the beginning to the end and this is what I can say:

After I have press the "Save" button on the view, the HttpPostedFileBase object is not null.
After I call the db.SaveChanges() method, one row is added in database's table.
When I call the GetImage, it doesn't return null.
But on the view, there's not image displayed

Thanks for helping

@bzlm. I just edited the question. It is not displaying on the view. While it showing that the image object on the controller is not null, a row is added in the database, GetImage return a value as well, but there is nothing on the view, i.e. the alt message is displayed instead. — Richard77
– Richard77, Commented Aug 31, 2011 at 17:19
then you should concentrate your question on why viewing the image doesn't work. If you're sure the image exists in your database, and you're sure it gets loaded correctly, then something is wrong with your action method that displays the image. What is the actual HTTP response sent to your browser by GetImage (use FireBug or Fiddler or similar)? — bzlm
– bzlm, Commented Aug 31, 2011 at 17:31

Martin · Accepted Answer · 2011-08-31 17:26:44Z

2

File should be FileContentResult since it is bytes and not an actual file on the disk. And img should be prod, correct?

public FileContentResult GetImage(int productID)
{
    Product prod = repository.Products.FirstOrDefault(p => p.ProductID == productID);
    if (prod != null)
    {
        return new FileContentResult(prod.ImageData, prod.ImageMimeType);
    }
    else
    {
        return null;
    }
}

edited Aug 31, 2011 at 17:26

answered Aug 31, 2011 at 17:01

Martin

11.1k8 gold badges53 silver badges77 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Richard77 Over a year ago

I'm sorry, I made a mistake while writting. Is prod instead of img, but that didn't change anything. Moreover, when using FileContentResult, I get the following message: "FileContentResult is a type but it is being used like a variable"

Martin Over a year ago

@Richard77 - Sorry, I had a type too ... forgot the new keyword.

Richard77 Over a year ago

after adding new, I didn't get the error anymore. Unfortunately, I still could not display anything. I believe that has to do with the way I am saving the file. Just before the hurricane IRENE, I saw a similar question on stackoverflow. But, I didn't bookmark the page, after the power loss, I lost also the page. Someone suggested a different way of processing HttpPostedFileBas in the controller, and it worked for him. But, I can't find the thread.

Martin Over a year ago

@Richard77 - what is your ImageMimeType ... is it the correct ContentType, like "image/jpeg"

Tieson T. · Accepted Answer · 2011-10-17 04:17:50Z

1

Modify your action method like so:

<img width="150" height="150" src = "@Url.Action("GetImage", "Home", new { @id = Model.ProductID })" />

Other than that small difference (adding the id parameter), your code is very similar to mine, and my images load just fine. BTW, if you look at the HTML source for your page, do you see:

/GetImage/<some number here>

or

/GetImage/

as the value of your src attribute? If the latter, this should definitely fix the problem. If the former, you may need to enable GET requests.

answered Oct 17, 2011 at 4:17

Tieson T.

21.2k6 gold badges82 silver badges99 bronze badges

Comments

LaserBeak · Accepted Answer · 2011-10-05 23:12:50Z

0

Here's the answer to get that Steven Sanderson example working, change your saving procedure as such:

            if (image != null)
            {

                var product = new Product();

                product.FileName = image.FileName; //<- optional filename
                product.ImageMimeType = image.ContentType;
                int length = image.ContentLength;
                byte[] buffer = new byte[length];
                image.InputStream.Read(buffer, 0, length);
                product.ImageData = buffer;

              //Save product to database 

            }

answered Oct 5, 2011 at 23:12

LaserBeak

3,29510 gold badges45 silver badges75 bronze badges

Comments

LadyRoot · Accepted Answer · 2012-03-13 20:53:47Z

I had the same problem, too. Just change the part of Edit method in controller to sth like this:

 if (image != null)
            {
                mvcImages img = db.mvcImages.Where(p => p.p_id == prod.p_id).FirstOrDefault();
                prod.p_imageMimeType = image.ContentType;
                byte[] buffer = new byte[image.ContentLength];
                image.InputStream.Read(buffer, 0, image.ContentLength);
                prod.p_imageData = buffer;
                img.p_imageMimeType = prod.p_imageMimeType;
                img.p_imageData = prod.p_imageData;
                db.SaveChanges();
            }

That works fine. Also remember to save changes within the same brackets as your "if" command.

kleopatra · Accepted Answer · 2013-01-08 16:59:00Z

0

Even simpler resolution is to just change the following line in your product class:

change from:

public byte ImageData {get;set;}

To:

public byte[] ImageData{get;set;}

edited Jan 8, 2013 at 16:59

kleopatra

51.6k28 gold badges103 silver badges220 bronze badges

answered Jan 8, 2013 at 16:38

Darren

1

Comments

Ricardo Ruiz Romero · Accepted Answer · 2013-08-22 22:03:29Z

0

I run into the same problem.. try this:

public ActionResult Edit(Product product, HttpPostedFileBase image)
{
  if(ModelState.IsValid)
  {
     if(image != null)
     {
       product.ImageMimeType = image.ContentType;
       product.ImageData = new byte[image.ContentLength];

       iname.InputStream.Position = 0; // This is what makes the difference

       image.InputStream.Read(product.ImageData, 0, image.ContentLength); 
     }

//...Save product in the database using Entity Framework

}

answered Aug 22, 2013 at 22:03

Ricardo Ruiz Romero

1551 silver badge11 bronze badges

Comments

DiegoS · Accepted Answer · 2013-10-25 18:57:07Z

0

the problem is in Action method.. it should be you has to change de name of the Controller... "GetImage" function is in "Admin" Controller.. The rest of the code is fine...

answered Oct 25, 2013 at 18:57

DiegoS

1

Comments

Mohit Jain · Accepted Answer · 2014-05-24 10:53:17Z

0

Simple Open the Products.cs file in your entities folder and change

public byte ImageData {get;set;}

To:

public byte[] ImageData{get;set;}

edited May 24, 2014 at 10:53

Mohit Jain

30.6k8 gold badges80 silver badges104 bronze badges

answered May 24, 2014 at 10:33

Salem Kosemani

1011 silver badge8 bronze badges

1 Comment

Mohit Jain Over a year ago

Please explain your answer in brief so that it more useful for OP and other readers.

Collectives™ on Stack Overflow

ASP.NET MVC3: upload image and save it to database

8 Answers 8

4 Comments

Comments

Comments

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

8 Answers 8

4 Comments

Comments

Comments

Comments

Comments

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related