i made Eulerian path algorithm(Euler-path). what's the problem?

Question

I made an Eulerian path algorithm, what's the problem?

#include <cstdio>
#include <vector>
#include <iostream>
#include <list>
using namespace std;
int graph[1000][1000];  // 1<n<1000
int n; // 그래프는 n x n 
int i, j, degree[1000] = {},f=1;
list<int> lt1;
void oiler(int u) {
        for(int v=0;v<n;v++){
            while (graph[u][v]>0) {
                graph[u][v]--;
                graph[v][u]--;
                oiler(v);
                }
        }
        lt1.push_back(u);
 }
int main(void) {
    cin >> n;
    for (i = 0; i < n; i++) { 
        for (j = 0; j < n; j++) {
            cin >> graph[i][j];
            sum += graph[i][j]; 
        }
    }
    oiler(0);
    lt1.reverse();
    list<int>::iterator iter = lt1.begin();
    for(iter=lt1.begin(); iter!=lt1.end(); iter++) 
    { 
        printf("%d ", *iter+1);
    } 
}

input is

6 
0 1 0 1 1 1
1 0 1 1 1 0
0 1 0 1 0 0
1 1 1 0 1 0
1 1 0 1 0 1
1 0 0 0 1 0

output is

1 2 3 4 1 5 2 4 5 6 1

it makes works and makes true output but not passed ... let me know if i missed anything

"what's the problem?" - Try to describe the problem. What is the output you expect for that input? — Ted Lyngmo
– Ted Lyngmo, Commented Jul 6, 2021 at 5:34

Swift - Friday Pie · Accepted Answer · 2021-07-06 06:36:33Z

2

You're missing definition of sum, this could not compile. Did you initialize it? Was it your intention to add 1 to every element: *iter+1?

Also you're wasting time on reversing list. You just can use push_front for std::list. In other cases you can also iterate in reverse order. In C++20 with its std::views::

// needs #include <ranges>

for (auto const& item : lt1| std::views::reverse) {
    std::cout << item << " ";
}

In C++11:

for (auto iter = lt1.rbegin(), ei = lt1.rend(); iter != ei; ++iter) {
     std::cout << *iter << " ";
}

For repeated use there are some way to do it through adapters.

edited Jul 6, 2021 at 6:36

answered Jul 6, 2021 at 6:30

Swift - Friday Pie

15.5k3 gold badges26 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

schorsch312 · Accepted Answer · 2021-07-06 05:44:20Z

1

I assume, that you are doing an online coding challenge and that some visible tests pass, but the entire testsuite fails, right? Please update your problem describtion in order to make clear what your error is.

Nevertheless,

for(iter=lt1.begin(); iter!=lt1.end(); iter++) 
{ 
    printf("%d ", *iter+1);
}

is a bad idea, since your are trying to read beyond the end of the list. You will not find meaningful data there, especially if the list is empty (n==0).

Try

for (auto const& item : lt1)
{
    std::cout << item;
}

answered Jul 6, 2021 at 5:44

schorsch312

5,7745 gold badges35 silver badges66 bronze badges

Collectives™ on Stack Overflow

i made Eulerian path algorithm(Euler-path). what's the problem?

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related