If else in Python

Question

I have the following function, when I call it's printing out the mess but if the if condition is false than it's not going the else branch, what I'm doing wrong?

def lidarMessageHandler( self, mess ):
        print( mess );
        #Check if I received the right command
        if( COMMANDTABLE[commandList[self.clientname]['lastcommand']]['id'] == mess['commandName'] ):
            print( 'if' )
            #Check if it's a blocking command            
            commandList[self.clientname]['isready'] = True
            if( self.start ):
                self.waitingForSettingsHandler( mess )
                return                           
        else:
            error = "I waited the answer for the following command %s but I received % command from %s " % self.lastCommand, mess['commandName'], self.clientname
            self.reiseError( error )
            isRunning[self.clientname] = False
            print( 'else' );

It seems valid. The only weird thing I see is reiseError(). Shouldn't that be raiseError() ? — ypercubeᵀᴹ
– ypercubeᵀᴹ, Commented Jul 25, 2011 at 8:17
Your else condition is probably connected with your inner if. Check your indentation. — Paolo Moretti
– Paolo Moretti, Commented Jul 25, 2011 at 8:19
@Paolo: I guess you are right. Identation is 8 first, then it becomes 4 in the inner level. — ypercubeᵀᴹ
– ypercubeᵀᴹ, Commented Jul 25, 2011 at 8:21
From the message, I printed out, and the if statement will be false. — Mokus
– Mokus, Commented Jul 25, 2011 at 8:27

MByD · Accepted Answer · 2011-07-25 08:22:27Z

3

You probably get an exception here:

error = "I waited the answer for the following command %s but I received % command from %s " % self.lastCommand, mess['commandName'], self.clientname
                                                                         ^

You should add s:

error = "I waited the answer for the following command %s but I received %s command from %s " % self.lastCommand, mess['commandName'], self.clientname
                                                                         ^

(I assume mess['commandName'] is a string)

answered Jul 25, 2011 at 8:22

MByD

138k30 gold badges269 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Mokus Over a year ago

Yes, it's a string, but I'm not getting this error, because the program not going in the else branch.

MByD Over a year ago

Just to make it clear, have you debugged it and see that it doesn't go the the else branch or you only assume?

Ferdinand Beyer · Accepted Answer · 2011-07-25 08:22:48Z

2

When the condition in your if statement evaluates to False, the else block is most certainly executed. What makes you think otherwise?

I suspect that your code raises an exception that you seem to ignore or silence in an outer try-except block. For example, the line

error = "I waited the answer for the following command %s but I received % command from %s " % self.lastCommand, mess['commandName'], self.clientname

will raise a TypeError, since you are passing 3 arguments but only have 2 placeholders, as you seem to have forgotten the "s" near "I received % command".

answered Jul 25, 2011 at 8:22

Ferdinand Beyer

67.6k18 gold badges160 silver badges147 bronze badges

Comments

Zaur Nasibov · Accepted Answer · 2011-07-25 08:23:36Z

2

If "self.reiseError" actually raises an error, you'll never get to isRunning[self.clientname] = False.

By the way, there is no need to use parenthesis in if statements as if it was C-syntax-derived language.

answered Jul 25, 2011 at 8:23

Zaur Nasibov

22.7k12 gold badges60 silver badges86 bronze badges

Comments

agf · Accepted Answer · 2011-07-25 08:20:10Z

1

Could it be going to the if branch but your print just isn't getting flushed out of the buffer?

Also, self.reiseError( error ) looks like a misspelling to me, so you should get an AttributeError there.

An indentation error that doesn't show up after the paste to Stack Overflow is also possible.

answered Jul 25, 2011 at 8:20

agf

178k45 gold badges300 silver badges241 bronze badges

Collectives™ on Stack Overflow

If else in Python

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related