How to concatenate a string with XML strings with setText and values coming from the view

Question

I have seen many Q&A on stack about it but for some reason they do not work in my case.

I think it might be because I'm working with elements from and to the view directly.

This code is working;

public class MainActivity extends AppCompatActivity {

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
    }

    public void btnOnClickRegister(View view){
     TextView txtEmail = findViewById(R.id.txtEmail);
     EditText edtTxtEmail = findViewById(R.id.edtTxtEmail);
     txtEmail.setText("Email "+ edtTxtEmail.getText().toString()); //hardcoded and will not translate
    }
}

In the strings.xml;

<string name="email">Email</string>

I get the following warning;

Do not concatenate text displayed with setText. Use resource string with placeholders.

Most Q&A resolve this like so;

getString(R.string.email, VarContainingEmail);

with an XML that look like this;

<string name="email">Email %s</string>

If I try that I get the following warning;

Cannot resolve method 'getString' in 'TextView'

I'm just starting with android studio and would like to resolve this right off the start.

I'm using Android Studio version 4.0.1

Raj · Accepted Answer · 2020-09-16 22:05:42Z

1

Please try once this way, let me know if doesn't work

<string name="email">Email, %1$s!</string>

txtEmail.setText(getString(R.string.email, edtTxtEmail.getText().toString()));

answered Sep 16, 2020 at 22:05

Raj

1,6552 gold badges13 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

MadeInDreams Over a year ago

I thought so to but i'm getting ; Format string 'email' is not a valid format string so it should not be passed to String.format

Marco Pierucci Over a year ago

can you show how are you actually trying this approach?

MadeInDreams Over a year ago

I got it! I had to update all value res file. I was only updating one so some of them where not valid string. After updating all languages it fixed the error.

Raj Over a year ago

Exactly, @MadeInDreams please show what changes you have made to the code. Also tell whether this code is inside fragment or activity. If fragment use getContext() to call getString(). If activity use this to call getString()

benjiii · Accepted Answer · 2020-09-17 16:13:15Z

1

You may need to use the context to get access to getString:

context.getString(R.string.email, VarContainingEmail);

where context could be this if you are in the activity

Edit: So if you are in a view, let's say this view is the variable view, you can use: view.getContext().getString(R.string.email, VarContainingEmail);

edited Sep 17, 2020 at 16:13

answered Sep 16, 2020 at 22:16

benjiii

5635 silver badges10 bronze badges

2 Comments

MadeInDreams Over a year ago

How do I declare this variable and assign a value to it in my context? This variable doesn't exist in my context because i'm reading the value from the view.

benjiii Over a year ago

in that case, you can access the context using: view.getContext(), I edited my answer. Your view could be accessible using this, in that case you could use this.getContext()

Collectives™ on Stack Overflow

How to concatenate a string with XML strings with setText and values coming from the view

2 Answers 2

4 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related