Modifying an objects property inside a forEach loop

Question

I am looking to set the

opponent = search_abbreviation

teams is an array of team objects that, before the loop, look like:

var team = {
          teamId: team_id,
          teamAbbreviation: abbreviation,
          gamePlayedId: game_id,
          totalPlaysFor: offensePlays,
          totalYardsFor: offenseYds,
          yardsPerPlayFor: offenseAvgYds,
          opponent: '',
          totalPlaysAgainst: 0,
          totalYardsAgainst: 0,
          yardsPerPlayAgainst: 0
        };

I have the following code to find the opponent by matching the gamePlayedId's to each other, then it will update the defensive(against) stats and the opponent properties. What am I doing wrong that will not allow me to modify the opponent property?

var teams = [
{
          teamId: 0,
          teamAbbreviation: 'abbreviation1',
          gamePlayedId: 11,
          totalPlaysFor: 12,
          totalYardsFor: 13,
          yardsPerPlayFor: 14,
          opponent: 'op',
          totalPlaysAgainst: 0,
          totalYardsAgainst: 0,
          yardsPerPlayAgainst: 0
},
{
          teamId: 1,
          teamAbbreviation: 'abbreviation2',
          gamePlayedId: 11,
          totalPlaysFor: 12,
          totalYardsFor: 13,
          yardsPerPlayFor: 14,
          opponent: 'op2',
          totalPlaysAgainst: 0,
          totalYardsAgainst: 0,
          yardsPerPlayAgainst: 0
}];

const result = teams.forEach(({ teamAbbreviation, gamePlayedId, teamId }) => {
      var search_gamePlayedId = gamePlayedId;
      var search_teamId = teamId;
      var search_abbreviation = teamAbbreviation;
      teams.forEach(({ opponent, gamePlayedId, teamId }) => {
        if (search_gamePlayedId === gamePlayedId && search_teamId !== teamId) {
          opponent = search_abbreviation;
          // Modify more properties
        }
      });
    });
    
console.log(result)

qiAlex · Accepted Answer · 2020-02-20 22:08:35Z

2

opponent links to a different memory space than teams[n].opponent in your code.

teams.forEach(({ opponent, gamePlayedId, teamId }, index) => {... // adding index

// then 
teams[index].opponent = 'something'

or

teams.forEach(team => {
    team.opponent = 'something'
})

answered Feb 20, 2020 at 22:08

qiAlex

4,3562 gold badges22 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Derek Lawrence · Accepted Answer · 2020-02-21 17:50:56Z

0

teams.forEach( (team1) ) => {
  teams.forEach( (team2) => {
    if (team1.gamePlayedId === team2.gamePlayedId && team1.teamId !== team2.teamId) {
      team2.opponent = team1.teamAbbreviation;
      // Modify more properties
    }
  });
});

edited Feb 21, 2020 at 17:50

answered Feb 20, 2020 at 22:08

Derek Lawrence

1,6282 gold badges17 silver badges37 bronze badges

1 Comment

Matthew Spahr Over a year ago

I did not think of this but it seems to give me exactly what I am looking for. This is now giving me benefits beyond what I posted. Thanks a ton!

Collectives™ on Stack Overflow

Modifying an objects property inside a forEach loop

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related