Change Properties of Items using a forEach Method (javascript)

Question

I'm using a javascript forEach method to iterate over items in an array, but it's throwing an error when I try and do something with the items.

In the code below when I console log 'item' it gives the desired behavior of logging 'div1, div2, div3' to the console. However, when I try and make a change to these items it won't allow it. The examples of using a forEach method in JS when you Google it is very abstract.

How do I use this method to change the background colors or other properties of the items?

Codepen link is here https://codepen.io/emilychews/pen/boJBKB

JS

var div1 = document.getElementById('div1');
var div2 = document.getElementById('div2');
var div3 = document.getElementById('div3');

var myArray = ['div1','div2','div3']

myArray.forEach(function(item){

  console.log(item);

  item.style.backgroundColor = "blue";  

})

CSS

.div {height: 50px; width: 50px; background-color: red; margin-bottom: 10px;}

HTML

<div class="div" id="div1"></div>
<div class="div" id="div2"></div>
<div class="div" id="div3"></div>

Any help would be awesome

Emily

That array is an array of strings, not an array of those variables — Patrick Evans
– Patrick Evans, Commented Oct 21, 2017 at 21:32

ferhado · Accepted Answer · 2017-10-21 21:36:01Z

3

Remove the quotes like: var myArray = [div1,div2,div3]

answered Oct 21, 2017 at 21:36

ferhado

2,6042 gold badges17 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

LiranC · Accepted Answer · 2017-10-21 21:37:50Z

0

your myArray contains Strings, not Dom Nodes. try this code:

var div1 = document.getElementById('div1');
var div2 = document.getElementById('div2');
var div3 = document.getElementById('div3');

var myArray = [div1,div2,div3]

myArray.forEach(function(item){
  console.log(item);
  item.style.backgroundColor = "blue";  
})

answered Oct 21, 2017 at 21:37

LiranC

2,4802 gold badges31 silver badges58 bronze badges

Collectives™ on Stack Overflow

Change Properties of Items using a forEach Method (javascript)

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related