How to access an array index of an Object instance

Question

Good day!

I am wondering How can I access an array index of an Object instance.

My code is as follows:

public class PokerPlayer {

    private String name = null;
    private Card [] cardsOnHand = new Card[5]; 

    //getter and setter
}

What i want is to access the cardsOnHandArray[index] so that i can call it on another class and set the values per index...

public class PokerGame {
      public static void main (String [] Args){
      PokerPlayer players []= new PokerPlayer[4];
      for(PokerPlayer player : players){
          for(int i =0; i<5; i++){
            //ACCESS cardsOnHand index i and store something on it...
          }
        }
    }
}

Any advice would be highly appreciated. How can i also improve my OO design? Thank you in advance

You should really avoid magic numbers, maybe get rid of 'i<5' and get the value from the Card array, i.e 'i<player.getCardsOnHand.length'. — toc777
– toc777, Commented May 5, 2011 at 15:56

yurib · Accepted Answer · 2011-05-05 15:46:51Z

4

public class PokerPlayer {
...
public Card getCard(int index) {
  return this.cardsOnHand[index];
}

public void setCard(int index, Card card) {
  this.cardsOnHand[index] = card;
}
...
}

then use:

player.getCard(i);
player.setCard(i,new Card());

answered May 5, 2011 at 15:46

yurib

8,1573 gold badges32 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jeremy · Accepted Answer · 2011-05-05 15:44:49Z

3

You almost have it. Just call this inside your inner loop:

cardsOnHand[i] = new Card();

Of course, change what is being assigned to the array according to your requirements.

answered May 5, 2011 at 15:44

Jeremy

22.5k4 gold badges71 silver badges82 bronze badges

2 Comments

newbie Over a year ago

but i want to store something in the array cardsOnHand [5]

Jeremy Over a year ago

There is no such thing as cardsOnHand[5] if the length of the array is 5. The index values would be 0, 1, 2, 3, 4.

GuruKulki · Accepted Answer · 2011-05-05 15:46:59Z

1

you can do as:

for(PokerPlayer player : players){
          for(int i =0; i<5; i++){
            Card[] cards= player[i].getCardsOnHand();
            cards[i] = new Card();
          }
        }

answered May 5, 2011 at 15:46

GuruKulki

26.6k55 gold badges148 silver badges206 bronze badges

Comments

Kyle · Accepted Answer · 2011-05-05 15:47:59Z

1

This should work:

public class PokerGame {
  public static void main (String [] Args){
  PokerPlayer players []= new PokerPlayer[4];
  for(PokerPlayer player : players){
      for(int i =0; i<5; i++){
        Card card = player.cardsOnHand[i];
      }
    }
}

}

answered May 5, 2011 at 15:47

Kyle

4,2381 gold badge36 silver badges42 bronze badges

Comments

brian_d · Accepted Answer · 2011-05-05 15:49:23Z

1

Since your cardsOnHand array is private, you have to use your (unprovided) setter function. Which could be something like

public void setCard(int index, Card value){
   cardsOnHand[index] = value;
}

And in used in your loop as
player.setCard(i, something)

answered May 5, 2011 at 15:49

brian_d

11.4k5 gold badges51 silver badges73 bronze badges

Comments

MarcoS · Accepted Answer · 2011-05-05 15:51:39Z

1

Assuming that your PokerPlayer has a getter for the cardsOnHand array:

public class PokerGame {
      public static void main (String [] Args){
      PokerPlayer players []= new PokerPlayer[4];
      for(PokerPlayer player : players){
          for(int i =0; i<5; i++){
                player.getCardsOnHand()[i] = new Card();
          }
        }
    }
}

However, I think that a better solution is to add a method

public void setCard(Card card, int index) {
    assert index < 5;
    cardOnHands[index] = card
}

to your PokerPlayer.

answered May 5, 2011 at 15:51

MarcoS

13.6k7 gold badges45 silver badges64 bronze badges

Collectives™ on Stack Overflow

How to access an array index of an Object instance

6 Answers 6

Comments

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

2 Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related