Concatenate Strings In For Each Loop

Question

I am using two for each loops to concatenate values into ONE variable so I can write the value to Word in a Find/Replace method. My issue is that the below syntax will write the values to the Console twice so this is written to the Console

Shirt - SH11
Hat - HA22
Socks - SO33
Shirt - SH11
Hat - HA22
Shirt - SH11

What I desire to be written to the console is the values just once like the below:

Shirt - SH11
Hat - HA22
Socks - SH11

This is my syntax:

DataTable table = new DataTable();
table.Columns.Add("Name", typeof(string));
table.Columns.Add("ItemsSold", typeof(string));
table.Columns.Add("ItemIDs", typeof(string));
table.Rows.Add("James Jo", "Shirt; Hat; Socks;", "SH11; HA22; SO33");

var itemsSold = table.Rows[0].Field<string>("ItemsSold").Split(new string[] {"; "}, StringSplitOptions.RemoveEmptyEntries);
var ItemIDs = table.Rows[0].Field<string>("ItemIDs").Split(new string[] {"; "}, StringSplitOptions.RemoveEmptyEntries);

string displayformat = "";

foreach (string is in itemsSold)
{
    foreach (string id in ItemIDs)
    {
        string s = is.Replace(";", "");
        string d = id.Replace(";", "");
        displayformat += s + " - " + d + Environment.NewLine;
    }
}

Console.WriteLine(displayformat);

use itemsSold.Zip(ItemIDs, (l, r) => l + " - " + r + Environment.NewLine) — Cinchoo
– Cinchoo, Commented Jan 2, 2019 at 0:36
Please read stackoverflow.com/questions/6638044/… to learn about constructing strings. — Alexei Levenkov
– Alexei Levenkov, Commented Jan 2, 2019 at 3:36

Anu Viswan · Accepted Answer · 2019-01-02 05:46:09Z

7

If you really want to do this in loop, you need to modify it as

for(int i=0;i<itemsSold.Count();i++)
{
    string s = itemsSold[i].Replace(";", "");
    string d = ItemIDs[i].Replace(";", "");
    displayformat += s + " - " + d + Environment.NewLine;
}

But, please note that this can be easily done with the Zip Method. Instead of the entire Loop, you can write

displayformat = string.Join(Environment.NewLine,
                     itemsSold.Zip(ItemIDs, 
                     (items, ids) => $"{items} - {ids}").Replace(";",string.Empty));
Console.WriteLine(displayformat);

You can read on Enumerable.Zip in here

edited Jan 2, 2019 at 5:46

answered Jan 2, 2019 at 0:43

Anu Viswan

18.2k4 gold badges27 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Enigmativity Over a year ago

Don't forget a final .Replace(";", "") on the produced string. Also the template string should be $"{items} - {ids}".

Anu Viswan Over a year ago

@Enigmativity thanks for pointing out, have changed it accordingly

Joel Coehoorn Over a year ago

The Replace() is only needed at all because of the sloppy Split() earlier in the question code, but c'est la vie

Enigmativity Over a year ago

@AnuViswan - I'd just do the .Replace(...) once at the end. Keep the code cleaner. Just a suggestion. :-)

Satya · Accepted Answer · 2019-01-02 11:15:57Z

0

You can also use Distinct() key word. hold the value into list and filter by Distinct()

answered Jan 2, 2019 at 11:15

Satya

95 bronze badges

Collectives™ on Stack Overflow

Concatenate Strings In For Each Loop

2 Answers 2

4 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related