CMake - add_executable called with incorrect number of arguments

Question

I am trying to organize a C++ project which starts to have a lot of files. I would like to create two executables which share some source file using Cmake. I have found an interesting procedure here:

How to add source files in another folder

Below is my version of the thing

file(GLOB Common_sources RELATIVE "Common" "*cpp")
file(GLOB Mps_sources RELATIVE "Mps" "*.cpp")                 
file(GLOB Mss_sources RELATIVE "Mss" "*.cpp") 

add_executable(test_mss ${Common_sources} ${Mss_sources}) 
add_executable(test_mps ${Common_sources} ${Mps_sources})

But CMake complains

CMake Error at src/CMakeLists.txt:44 (add_executable):
add_executable called with incorrect number of arguments

CMake Error at src/CMakeLists.txt:45 (add_executable):
add_executable called with incorrect number of arguments

It says to look at CMakeOutput.log, but the file is really too long, I can not find useful information.

I checked the CMake documentation, it seems that it can take a second source as an additional argument. https://cmake.org/cmake/help/v3.0/command/add_executable.html

I would like to find the source of this bug. I have the feeling that I am missing something obvious here.

Check your souces lists. If they are empty, then add_executable will fail. You may use something like message ("Common ${Common_sources}") to output your sources list. — Innokentiy Alaytsev
– Innokentiy Alaytsev, Commented May 11, 2018 at 22:25

Tsyvarev · Accepted Answer · 2018-05-12 10:47:49Z

5

The error you get is because source list, passed to add_executable, is actually empty.

Correct way for collect sources in Common/ subdirectory is:

file(GLOB Common_sources "Common/*.cpp")

In command file(GLOB) RELATIVE option doesn't specify search directory. Instead, it just tells CMake to generate relative paths instead of absolute:

If RELATIVE flag is specified, the results will be returned as relative paths to the given path.

Assuming

file(GLOB Common_sources "Common/*.cpp")
# gets: /<path-to-source>/Common/my_source.cpp

then (also note to absolute path in RELATIVE option)

file(GLOB Common_sources RELATIVE "${CMAKE_CURRENT_SOURCE_DIR}/Common" "Common/*.cpp")
# gets: my_source.cpp

and (when files are not under RELATIVE directory)

file(GLOB Common_sources RELATIVE "${CMAKE_CURRENT_SOURCE_DIR}/Mps" "Common/*.cpp")
# gets: ../Common/my_source.cpp

answered May 12, 2018 at 10:47

Tsyvarev

67.7k18 gold badges141 silver badges187 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Raphael D. Over a year ago

It solved my problem. I am just wondering whether it contradicts the first part of the accepted answer here. stackoverflow.com/questions/25609692/…

Tsyvarev Over a year ago

Yes, my answer contradicts the referenced one. I have added a comment to that answer.

usr1234567 · Accepted Answer · 2018-05-11 23:16:18Z

2

You have to quote the variables.

add_executable(test_mss "${Common_sources}" "${Mss_sources}")

Otherwise for an empty variable, CMake replaces the variable by nothing and the number of arguments seems to be wrong.

Similar problem: https://stackoverflow.com/a/39733128/2799037

answered May 11, 2018 at 23:16

usr1234567

23.8k20 gold badges125 silver badges141 bronze badges

1 Comment

Tsyvarev Over a year ago

Quoting a variable's dereference, when the variable can be empty, has a sence, but only when empty string is acceptable. In case of add_executable empty strings are not acceptable (name of source file cannot be empty). So quoting has no sence with add_executable.

Eric Aya · Accepted Answer · 2023-02-11 12:06:11Z

0

None of the suggested answers worked for me.

This works:

add_executable(<executable_name> <source_file_name>)

edited Feb 11, 2023 at 12:06

Eric Aya

70.2k36 gold badges190 silver badges266 bronze badges

answered Feb 11, 2023 at 6:10

jbhntr861

1

Collectives™ on Stack Overflow

CMake - add_executable called with incorrect number of arguments

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related