AngularJS error injecting module

Question

I'm trying to develop a login with cookies check if a user is already logged or not.

In order, I include the app:

angular.module('ELOAuthentication', [
    'AuthenticationService',
    'ngRoute',
    'ngCookies',
    'angular-loading-bar'
])

Then the service

angular.module('ELOAuthentication').factory('AuthenticationService', function ($rootScope, $scope, $http) {

    var service = {};

    service.Login = function (email, password, callback) {
        var Url = '/api/user/GetLoginByEmailPassword';

        $http.then(Url, { email: email, password: password }).success(
            function (response) {
                var data = response.data
                callback(data);
            }).catch(function (error) {
                console.log('ERROR GetLoginByEmailPassword: ' + error);
            });
    }

    service.SetCookie = function (email, password) {

    };

    service.ClearCookie = function () {

    };
});

Finally the AngularJS controller.

angular.module('ELOAuthentication').controller('LoginController', function ($rootScope, $scope, $http) {

    AuthenticationService.ClearCookie();

    $scope.init = function () {

    }

    $scope.login = function () {

    };
});

I receive the error:

Uncaught Error: [$injector:modulerr]

. What is wrong?

angular.module('ELOAuthentication', [ 'ngRoute', 'ngCookies', 'angular-loading-bar' ]) no need to include AuthenticationService in here — Kalaiselvan
– Kalaiselvan, Commented Dec 4, 2017 at 13:01
Also, you would have to return service at the end of factory. — Sajal
– Sajal, Commented Dec 4, 2017 at 13:02
and angular.module('ELOAuthentication').controller('LoginController', function ($rootScope, $scope, $http,AuthenticationService) { AuthenticationService you should add this — Kalaiselvan
– Kalaiselvan, Commented Dec 4, 2017 at 13:03
this is some old syntax, but shouldn't $http.then(...) be $http.post(...) instead? — Aleksey Solovey
– Aleksey Solovey, Commented Dec 4, 2017 at 13:14

Zooly · Accepted Answer · 2017-12-04 13:13:09Z

5

You don't need to inject Services in your module.

app.js

angular.module('ELOAuthentication', [
    'ngRoute',
    'ngCookies',
    'angular-loading-bar'
])

LoginController.js

angular.module('ELOAuthentication').controller('LoginController', function ($rootScope, $scope, $http, AuthenticationService) {

    AuthenticationService.ClearCookie();

    $scope.init = function () {

    }

    $scope.login = function () {

    };
});

As mentioned by Sajal, don't forget to return your service object:

AuthenticationService.js

angular.module('ELOAuthentication').factory('AuthenticationService', function ($rootScope, $scope, $http) {

    var service = {};

    service.Login = function (email, password, callback) {
        var Url = '/api/user/GetLoginByEmailPassword';

        $http.then(Url, { email: email, password: password }).success(
            function (response) {
                var data = response.data
                callback(data);
            }).catch(function (error) {
                console.log('ERROR GetLoginByEmailPassword: ' + error);
            });
    }

    service.SetCookie = function (email, password) {

    };

    service.ClearCookie = function () {

    };

    return service;
});

Official documentation

edited Dec 4, 2017 at 13:13

answered Dec 4, 2017 at 13:03

Zooly

4,7974 gold badges40 silver badges55 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

Michele Boscagin Over a year ago

Hi. Thanks a lot to all! Still have error:

Error: [$injector:unpr] http://errors.angularjs.org/1.6.4/$injector/unpr?p0=%24scopeProvider%20%3C-%20%24scope%20%3C-%20AuthenticationService

. I don't know why is unknown.

Zooly Over a year ago

Did you loaded it in your index.html? Something like : <script src="js/authentication.service.js"></script>

Michele Boscagin Over a year ago

Yes, load in order: jquery, angularjs, app, service, controller.

Zooly Over a year ago

Do you use a module bundler? Gulp/Grunt/Webpack or other?

Zooly Over a year ago

Ok, kind strange if you have to place run there, but glad it works :)

|

Collectives™ on Stack Overflow

AngularJS error injecting module

1 Answer 1

11 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

11 Comments

Your Answer

Sign up or log in

Post as a guest

Related