PHP Class variables with Constants

Question

I am getting a parse error on the lines with the constant (DEPLOYMENT). Why is this now allowed, or am I missing something.

Parse error: parse error, expecting `')'' in

class UploadComponent extends Object {

    private $config = array(
        'accessKey' => 'XXXX',
        'secretKey' => 'XXXX',

        'images' => array(
            'bucket' => DEPLOYMENT.'-files/images',
            'dns' => false
        ),

        'files' => array(
            'bucket' => DEPLOYMENT.'-files/files',
            'dns' => false
        ),

        'assets' => array(
            'bucket' => DEPLOYMENT.'-files/assets',
            'dns' => false
        )
    );
    ....
}

(sidenote) You dont want to have the dependency on the global constant in there anyway. — Gordon
– Gordon, Commented Oct 14, 2010 at 11:21
@Gordon why not? @pleasedontbelong really? What is the point of your comment. — Lizard
– Lizard, Commented Oct 14, 2010 at 11:55
because dependencies ought to be injected. If you rely on outside state, your class can no longer be used in isolation. You cannot have this class without also having the global constant. That's bad for maintenance and testing. — Gordon
– Gordon, Commented Oct 14, 2010 at 12:24

Tatu Ulmanen · Accepted Answer · 2010-10-14 11:18:26Z

7

You can't use variables when defining class vars. Initialize your array inside the constructor instead:

class UploadComponent extends Object {

    private $config;

    function __construct() {
        $this->config = array(
            'accessKey' => 'XXXX',
            'secretKey' => 'XXXX',

            'images' => array(
                'bucket' => DEPLOYMENT.'-files/images',
                'dns' => false
            ),

            'files' => array(
                'bucket' => DEPLOYMENT.'-files/files',
                'dns' => false
            ),

            'assets' => array(
                'bucket' => DEPLOYMENT.'-files/assets',
                'dns' => false
            )
        );
    }
}

answered Oct 14, 2010 at 11:18

Tatu Ulmanen

125k34 gold badges190 silver badges185 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Evert · Accepted Answer · 2010-10-14 11:20:44Z

5

The reason is that 'constants' can be defined dynamically. Their contents are therefore only known at run-time, and not compile-time.

answered Oct 14, 2010 at 11:20

Evert

101k18 gold badges136 silver badges221 bronze badges

Collectives™ on Stack Overflow

PHP Class variables with Constants

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related