Trouble creating string in Javascript

Question

I have a script as follows where element is a number:

function updateList(element) {
    var out_list = "<Select name='item" + element + "' onchange=getQualType(this.value, 'qualType" + element + "')>";
.... add options here ...
    out_list += "</Select>"
    document.getElementById('dropdown_list' + element).innerHTML = out_list;
}

However what is in the browser is:

<select name="item40" onchange="getQualType(this.value," 'qualtype40')="">
</script>

Can anyone point out what is causing the incorrect quotes in the output?

UPDATE

Spotted it:

    var out_list = "<Select name='item" + element + "' onchange=getQualType(this.value, 'qualType" + element + "')'>";

Single quote after bracket - thanks all.

The JS isn't "wrong" as to the select it's output, per se. Its writing out your select element literally (and thus, correctly). Your string that creates it is technically the issue. You could just create a handler for the select through JS, and handle the onchange event that way, instead :) — Geoff James
– Geoff James, Commented Aug 30, 2016 at 11:44
you have to put quotes around the onchange-script. this way, it can't contains any spaces, like the one before 'qualType" + element + "' — Thomas
– Thomas, Commented Aug 30, 2016 at 11:45

vaso123 · Accepted Answer · 2016-08-30 11:45:05Z

1

You can try this, you had problems at escaping quotes:

var out_list = '<select name="item' + element + '" onchange="getQualType(this.value, \'qualType' + element + '\')">';

answered Aug 30, 2016 at 11:45

vaso123

12.4k4 gold badges37 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ben Hillier · Accepted Answer · 2016-08-30 11:45:25Z

0

I would start by quoting the onChange. If you don't do it, the browser makes its own decisions:

 var out_list = "<Select name='item" + element + "' onchange=\"getQualType(this.value, 'qualType" + element + "');\">";

answered Aug 30, 2016 at 11:45

Ben Hillier

2,1041 gold badge11 silver badges15 bronze badges

Collectives™ on Stack Overflow

Trouble creating string in Javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related