Regex validating csv strings

Question

I have a TextField in javaFX where the background color changes accordingly to if the content is valid or not.

Valid:

987654321 1
987654321 21
0101 9 1
1701 91 1 2
4101 917 1 0 43
0801 9 178 2 0
0111 9 1 084 0

Invalid:

0101 9 1 0 1 0
3124
0314 9

Basically:

Only digits
First group 4 or 9 digits
If first group 9 digits -> only two groups in total
If first group 4 digits -> three, four or five groups in total
Group two and three digits 1-9999
Group four and five digits 0-9999

Now think one of these (valid) lines as one "Ident".

The current regex is:

final String base = "(\\d+\\s+\\d+)|(\\d+\\s+\\d+\\s+\\d+(\\s+\\d+)?(\\s+\\d+)?)|(\\d+\\s+\\d+\\s+\\d+)|(\\d+\\s+\\d+\\s+\\d+\\s+\\d+)|(\\d+\\s+\\d+\\s+\\d+\\s+\\d+\\s+\\d+)";

Which works great so far, but now I want to include csv. So I can type only one ident as I have used to, or multiple idents separated by comma (,), but not more than five idents in total.

My attempt:

final String pattern = String.format("(%s,?\\s*){1,5}",base);

This enables me to input this:

All the valid lines above
0101 9 1, 0101 9 2, 0101 9 3
0101 9 1, 987654321 21, 0101 9 3, 0101 9 4

And if I input more than 5 idents it turns invalid correctly. But if I input the invalid ident 0101 9 1 1 1 1 1 1 1 1 1 it still turns valid.

Any suggestions?

EDIT: This is the matching logic:

private final Predicate<String> typingPredicate = new Predicate<String>() {
    @Override
    public boolean apply(String input) {
        return input.matches(pattern);
    }
};

textField.textProperty().addListener(new ChangeListener<String>() {
    @Override
    public void changed(ObservableValue<? extends String> observableValue, String previous, String current) {
        if (current != null) {
            if (StringUtils.isEmpty(current) || typingPredicate.apply(current.trim())) {
                textField.getStyleClass().removeAll("invalid");
            } else {
                textField.getStyleClass().add("invalid");
            }
        }
    }
});

I am using com.google.common.base.Predicate for matching. Updatet my question with the matching logic. — Olav Gulbrandsen Blaaflat
– Olav Gulbrandsen Blaaflat, Commented Nov 17, 2015 at 12:53
Why not: (i) split the text on commas (ii) check that each ident is valid with your original regex and that the number of idents is less than 6? — assylias
– assylias, Commented Nov 17, 2015 at 12:57

AndreyS Scherbakov · Accepted Answer · 2015-11-17 13:25:55Z

3

The comma in your regexp is optional that fact allows "0101 9 1 1 1 1 1 1 1 1 1" to be freely parsed as two or more records.

To fix this, you may demand it to be either exactly one ident or several comma-separated ones:

final String pattern = String.format("(%s\\s*,\\s*){0,4}%s",base,base);

Also I would recommend to make base itself more strict with respect to your input rules, although it doesn't seem to be directly relevant to the issue.

answered Nov 17, 2015 at 13:25

AndreyS Scherbakov

2,8082 gold badges23 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Olav Gulbrandsen Blaaflat Over a year ago

Thank you, that was all I needed! :)

Cyrbil · Accepted Answer · 2015-11-17 13:32:39Z

Let's break things down:

Only digits:

The regex will have to match digits and spaces and use ^$ to match only that
First group 4 or 9 digits:

Straigh forward: \d{4}|\d{9}
If first group 9 digits -> only two groups in total

\d{9}\s\d the 9 digits group and the second
If first group 4 digits -> three, four or five groups in total

\d{4}(\s\d){2,4} the 4 digits group followed by 2 to 4 group
Group two and three digits 1-9999

1-9999 -> [1-9]\d{0,3}
Group four and five digits 0-9999

Easy one ... \d{1,4}

Then combining everything:

^ # match start of string
  (\d{4} # group start with 4 digits
    (\s[1-9]\d{0,3}){2} # group of 1-9999 twice
    (\s\d{1,4}){0,2} # group of 0-9999 zero to two times
  )|(\d{9} # group start with 9 digits
    \s[1-9]\d{0,3} # group of 1-9999
)$ # end of string match

Which gives:

^((\d{4}(\s[1-9]\d{0,3}){2}(\s\d{1,4}){0,2})|(\d{9}\s[1-9]\d{0,3}))$

You can try it live here

SomeJavaGuy · Accepted Answer · 2015-11-17 13:34:05Z

1

Here´s a solution to your problem. I modified the regex a little bit. Your pattern also somehow made the last of the invalid statement to be valid, at least for me. The basic problem that you are running into is, that your regex isn´t surrounded by brackets. So you are only adding the ,?\\s to the last statement and not to the complete regex statement.

Here´s a modified solution i came up with, that seems to validate everything as it should be doing.

public static void main(String[] args) {
    String[] inputs  = {"987654321 1",
                        "987654321 21",
                        "0101 9 1",
                        "1701 91 1 2",
                        "4101 917 1 0 43",
                        "0801 9 178 2 0",
                        "0111 9 1 084 0",
                        "0101 9 1 0 1 0",
                        "3124",
                        "0314 9"};
    String regex = "(((\\d{9}(\\s\\d*)))|(\\d{4}(\\s[1-9]\\d{0,3}){2}(\\s\\d{1,4}){0,2}))";
    String csvRegex = "("+ regex + ",\\s){0,4}"+regex;
    for(String s : inputs) {
        Matcher m = Pattern.compile(csvRegex).matcher(s);
        System.out.println(m.matches());
    }

    String falseCSVString = "987654321 1, 987654321 21, 1701 91 1 2, 0111 9 1 084 0, 0101 9 1 1 1 1 1 1 1 1 1";
    Matcher m = Pattern.compile(csvRegex).matcher(falseCSVString);
    System.out.println(m.matches());

    String rightCSVString = "987654321 1, 987654321 21, 1701 91 1 2, 0111 9 1 084 0, 0101 9 1";
    m = Pattern.compile(csvRegex).matcher(rightCSVString);
    System.out.println(m.matches());
}

edited Nov 17, 2015 at 13:34

answered Nov 17, 2015 at 13:17

SomeJavaGuy

7,3872 gold badges24 silver badges33 bronze badges

2 Comments

Aaron Over a year ago

I noticed that your second number in case the first number is composed of 9 digits does not follow the "digits 1-9999" rule, I'm not sure if it's meant to apply only to numbers following a first number composed of 4 digits.

SomeJavaGuy Over a year ago

@Aaron me neither, but i thought it would be the case. I guess OP would be saying something.

Aaron · Accepted Answer · 2015-11-17 13:36:34Z

1

I believe this regex answer all your requirements :

^\d{9} [1-9]\d{0,3}$|^\d{4}(?: [1-9]\d{0,3}){2}(?: \d{1,4}){0,2}$

You can try it here.

edited Nov 17, 2015 at 13:36

answered Nov 17, 2015 at 13:18

Aaron

24.9k2 gold badges41 silver badges61 bronze badges

1 Comment

Cyrbil Over a year ago

Fails for 987654321 11111111111 as your $ only match the second case (4 digits group)

Miss Chanandler Bong · Accepted Answer · 2020-04-02 17:30:24Z

Try

String ident = "\\s*(([0-9]{9}\\s+[1-9][0-9]{0,3})|(\\d{4}(\\s+[1-9]\\d{0,3}){2}(\\s+\\d{1,4}){2}))\\s*";

String regex = String.format("\\A%s(,%s){0,4}\\z", ident, ident);

SSCCE:

import java.util.regex.Pattern;

import javafx.application.Application;
import javafx.beans.binding.Bindings;
import javafx.beans.binding.BooleanBinding;
import javafx.scene.Scene;
import javafx.scene.control.TextField;
import javafx.scene.layout.StackPane;
import javafx.stage.Stage;

public class ValidatingTextFieldExample extends Application {

    private BooleanBinding valid ;

    @Override
    public void start(Stage primaryStage) {
        String ident = "\\s*(([0-9]{9}\\s+[1-9][0-9]{0,3})|(\\d{4}(\\s+[1-9]\\d{0,3}){2}(\\s+\\d{1,4}){2}))\\s*";

        String regex = String.format("\\A%s(,%s)*\\z", ident, ident);

        Pattern pattern = Pattern.compile(regex);

        TextField textField = new TextField();
        String INVALID_STYLE = "-fx-background-color: red;" ;
        textField.setStyle(INVALID_STYLE);

        valid = Bindings.createBooleanBinding(() -> 
            pattern.matcher(textField.getText()).matches(),
            textField.textProperty());

        valid.addListener((obs, wasValid, isValid) -> {
            if (isValid) {
                textField.setStyle("");
            } else {
                textField.setStyle(INVALID_STYLE);
            }
        });

        StackPane root = new StackPane(textField);
        primaryStage.setScene(new Scene(root, 350, 120));
        primaryStage.show();
    }

    public static void main(String[] args) {
        launch(args);
    }
}

Collectives™ on Stack Overflow

Regex validating csv strings

5 Answers 5

1 Comment

Comments

2 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

2 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related