C# save image to memory stream

Question

I just want to save an image bmp for my screen to a memory stream gut I get:

value cannot be null. parameter name encoder

I use this code

pmb = new Bitmap(Screen.PrimaryScreen.WorkingArea.Width, Screen.PrimaryScreen.WorkingArea.Height);
gc = Graphics.FromImage(pmb);
gc.CopyFromScreen(0, 0, 0, 0, new Size(pmb.Width, pmb.Height));
pb.Image = pmb;
pb.SizeMode = PictureBoxSizeMode.StretchImage;

try
{
    client = new TcpClient(mm.Text, 1430);
    ms = new MemoryStream();
    pb.Image.Save(ms, pb.Image.RawFormat);
    ms.Close();
    byte[] buffer = ms.GetBuffer();
    ns = client.GetStream();
    br = new BinaryWriter(ns);
    br.Write(buffer);
    br.Close();
    ns.Close();
    client.Close();
}
catch (Exception ex)
{
    MessageBox.Show(ex.Message);
}

Please debug your code and specify line where it throws (I'd be surprised if it is anywhere from this code). — Alexei Levenkov
– Alexei Levenkov, Commented Oct 5, 2015 at 23:00

Eric J. · Accepted Answer · 2015-10-05 22:42:39Z

2

You are accessing your MemoryStream after you close it

ms.Close();
byte[] buffer = ms.GetBuffer();

Also, if an Exception is ever thrown, you will not clean up resources. Make use of the using keyword for everything that implements IDisposable.

You need to rewind the memory stream after writing to it and before saving it out

ms.Seek(0, SeekOrigin.Begin);

answered Oct 5, 2015 at 22:42

Eric J.

151k65 gold badges353 silver badges563 bronze badges

Sign up to request clarification or add additional context in comments.

13 Comments

user5107123 Over a year ago

same i change the code ms.Close(); byte[] buffer = ms.GetBuffer();

itsme86 Over a year ago

@alexmike Changed it to what?

user5107123 Over a year ago

i searched in google maybe the problem of image format

Alexei Levenkov Over a year ago

@alexmike why are you using GetBuffer? ToArray is probably more suitable if you don't know what you are doing.

Alexei Levenkov Over a year ago

@EricJ. msdn.microsoft.com/en-us/library/…: "This method works when the memory stream is closed." (same for ToArray).

|

41 72 6c · Accepted Answer · 2020-12-15 17:17:53Z

-1

It is save memory

MemoryStream ms = new MemoryStream();
pictureBox_ad_cam_in.Image.Save(ms, System.Drawing.Imaging.ImageFormat.Jpeg);
kanvert = Convert.ToBase64String(ms.ToArray());

edited Dec 15, 2020 at 17:17

41 72 6c

1,7786 gold badges25 silver badges37 bronze badges

answered Oct 19, 2018 at 12:33

Amar Ruz

13 bronze badges

Collectives™ on Stack Overflow

C# save image to memory stream

2 Answers 2

13 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

13 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related