ImageButton problem - CommandArgument doesn't work

Question

I am rather new at asp.net.

I´m trying to use ImageButton to link to another page. ImageButton is inside a Repeater and the code is following:

<ul id = "ulMap"> 
    <asp:Repeater ID="Repeater1" runat="server" >
        <ItemTemplate>
            <li>
                <asp:ImageButton ID="ImageButton1" 
                                 CommandArgument='<%#Eval("Nav_ID") %>' 
                                 runat="server" 
                                 ImageUrl="~/Icons/Ny_mappa.png"
                                 onclick="ImageButton1_Click" />
                <br />
                <asp:LinkButton ID="lnkButton" 
                                CommandArgument='<%#Eval("Nav_ID") %>' 
                                runat="server" 
                                onclick="LinkButton3_Click" 
                                Text='<%#Eval("Nav_Name") %>'></asp:LinkButton>
            </li>
        </ItemTemplate>
    </asp:Repeater> 
</ul>

And the code behind is the following:

protected void LinkButton3_Click(object sender, EventArgs e)
{
    Guid guid = new Guid(((LinkButton)sender).CommandArgument);

    var query = from n in dc.Nemanet_Navigations
                where n.UserId == userGuid && n.Nav_pID == guid
                orderby n.Nav_Name ascending
                select n;

    Repeater1.DataSource = query;
    Repeater1.DataBind();
}

protected void ImageButton1_Click(object sender, ImageClickEventArgs e)
{
    Guid guid = new Guid(((ImageButton)sender).CommandArgument);

    var query = from n in dc.Nemanet_Navigations
                where n.UserId == userGuid && n.Nav_pID == guid
                orderby n.Nav_Name ascending
                select n;

    Repeater1.DataSource = query;
    Repeater1.DataBind();
}

Well, for the LinkButton this works fine but not for ImageButton. Protected void ImageButton1_Click never happens. Can anybody help?

Simon Hazelton · Accepted Answer · 2010-07-13 12:24:05Z

3

I thin you need to handle the Repeater_ItemCommand event to get this working properly. It'll probably save a bit of code as well.

MSDN Repeater ItemCommand

Also, if you're linking to another page do you need to postback to the page then perform some kind of redirection or would it make more sense to have that logic in the new page?

answered Jul 13, 2010 at 12:24

Simon Hazelton

1,25510 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kristof Claes · Accepted Answer · 2010-07-13 13:05:07Z

Instead of OnClick, you should you should OnCommand. Like this.

<ul id = "ulMap"> 
    <asp:Repeater ID="Repeater1" runat="server" >
        <ItemTemplate>
            <li>
                <asp:ImageButton ID="ImageButton1" 
                                 CommandArgument='<%#Eval("Nav_ID") %>' 
                                 runat="server" 
                                 ImageUrl="~/Icons/Ny_mappa.png"
                                 OnCommand="ImageButton1_Click" />
                <br />
                <asp:LinkButton ID="lnkButton" 
                                CommandArgument='<%#Eval("Nav_ID") %>' 
                                runat="server" 
                                OnCommand="LinkButton3_Click" 
                                Text='<%#Eval("Nav_Name") %>'></asp:LinkButton>
            </li>
        </ItemTemplate>
    </asp:Repeater> 
</ul>

And this (notice the CommandEventArgs instead of EventArgs and ImageClickEventArgs):

protected void LinkButton3_Click(object sender, CommandEventArgs e)
{
    Guid guid = new Guid(e.CommandArgument);

    var query = from n in dc.Nemanet_Navigations
                where n.UserId == userGuid && n.Nav_pID == guid
                orderby n.Nav_Name ascending
                select n;

    Repeater1.DataSource = query;
    Repeater1.DataBind();
}

protected void ImageButton1_Click(object sender, CommandEventArgs e)
{
    Guid guid = new Guid(e.CommandArgument);

    var query = from n in dc.Nemanet_Navigations
                where n.UserId == userGuid && n.Nav_pID == guid
                orderby n.Nav_Name ascending
                select n;

    Repeater1.DataSource = query;
    Repeater1.DataBind();
}

RPM1984 · Accepted Answer · 2010-07-13 12:44:50Z

1

You can't handle server-side events for repeater child controls like this.

Think of it this way - if there is 100 buttons, you need 100 event handlers for each button. ImageButton1_Click will only work for the ImageButton with the id of 1.

The answer is to wire up the ItemCommand event for your repeater.

Like this:

<asp:repeater id = "Repeater`" runat = "server" onItemCommand = "SomeEvent">

Then you handle the "SomeEvent" for all buttons that trigger this event:

protected void SomeEvent ( Object src, RepeaterCommandEventArgs e ) {  
      var whoClickedMe = ((ImageButton) e.CommandSource );
}

Here's a good article on doing this.

answered Jul 13, 2010 at 12:44

RPM1984

73.3k62 gold badges241 silver badges364 bronze badges

Collectives™ on Stack Overflow

ImageButton problem - CommandArgument doesn't work

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related