6

I have an web api controller 

using sport.BLL.Abstract;
using sport.BLL.Concrete;
using sport.DAL.Entities;
using sport.webApi.Models;
using AutoMapper;
using Microsoft.AspNet.Identity.EntityFramework;
using System;
using System.Collections.Generic;
using System.Linq;
using Microsoft.AspNet.Identity;
using Microsoft.AspNet.Identity.Owin;  
using Microsoft.Owin.Security;
using System.Net;
using System.Net.Http;
using System.Web.Http;
using System.Web;
using System.Web.WebPages.Html;

namespace sport.webApi.Controllers 
{
    public class AccountManageController : ApiController
    {
        [HttpPost]
        public System.Web.Mvc.ActionResult CreateAccount(CollaborateurModel item)
        {
            var user = new ApplicationUser { UserName = item.Username, Email = item.Email };
            var result = UserManager.CreateAsync(user, item.Password);
            if (result.Result.Succeeded)
            {

                var currentUser = UserManager.FindByName(item.Username);
                var roleresult = UserManager.AddToRole(currentUser.Id, item.Role);
                ajt_collaborator entity = Mapper.Map<CollaborateurModel, ajt_collaborator>(item);
                entity.id_user_fk = currentUser.Id;
                entity.is_deleted = false; 
                repo.CreateCollaborator(entity); 
                var response = new { Success = true }; 
                return  Json(response);


            }
            else
            {
                var errorResponse = new { Success = false, ErrorMessage = "error" };
                return  Json(errorResponse);
            }

        }
    }
}

I got an error in this line :

return Json(response);

the Json Method is not recognized!!! when I googled about that I get this link which indicates that Json method is included in System.Web.Mvc. Even I try to import this namespace I get the same error?

  1. So is the reason of this error?
  2. How can I fix it?
Improve this question
6
  • Why are you returning Json in a ActionResult method? It is not the answer to a question. However, it is an important issue. Commented Jun 9, 2015 at 8:03
  • Api controllers aren't meant to return ActionResult. You're mixing regular controllers with Api controllers. Commented Jun 9, 2015 at 8:03
  • 1
    As I guess, the problem is that you are inheriting from ApiController and Json is a member of System.Web.Mvc.Controller. Try using return new JsonResult { data = response };. Commented Jun 9, 2015 at 8:05
  • @YeldarKurmangaliyev It is a good idea but I don't need to send data but only the status ( success ou failure) . I need some thing like return new JsonResult{sucess =false} Commented Jun 9, 2015 at 8:10
  • 1
    @LamloumiAfif return new JsonResult { data = true }; works fine. Commented Jun 9, 2015 at 8:16

2 Answers 2

Reset to default
6

The problem is that you are inheriting from ApiController but Json is a member of System.Web.Mvc.Controller.

Try using JsonResult:

return new JsonResult { data = yourData; }

You can set any object to a data as it will be serialized to a JSON.

For instance, if you need to return only a result of operation, you can use it this way:

return new JsonResult { data = true; } // or false

However, it is a good practice to describe a result class and return objects.

Improve this answer
Sign up to request clarification or add additional context in comments.

1 Comment

According to the below link, ApiController does offer a Json() method. But according to my dev environment, it doesn't... Which is why I'm here! Is this documentation just nonsense? msdn.microsoft.com/en-us/library/…1(0)
5

How can I fix it?

The reason is in the fact that you aren't inheriting from Controller but from ApiController, where the former has Json(object o) as a method in it's base class, but that doesn't actually matter, as there is a fundamental problem with your approach.

ApiController which is used with WebAPI isn't meant to return an ActionResult, which is a concept that belongs to MVC. Instead, you simply return your POCO and let the WebAPI framework handle serialization for you:

public object CreateAccount(CollaborateurModel item)
{
    // Do stuff:
    if (result.Result.Succeeded)
    {
        return new { Success = true }
    }
    else
    {
        return new { Success = false, ErrorMessage = "error" };   
    }                               
}

You can set your formatter configuration in your Global.asax.cs file, and tell it exactly which ones to use (in your case, you'll want the JsonMediaTypeFormatter).

Improve this answer

4 Comments

I get in this line return result.Result.Succeeded ? new { Success = true } : new { Success = false, ErrorMessage = "error" }; this error Type of conditional expression cannot be determinated because there is no implicit conversion
@LamloumiAfif You're right, I tested this with the wrong anon type creation. Fixed the code.
Change it to if-else. The ternary operator ?: requires both objects to be of the same type. In ypour case they're not. It's been corrected in the answer.
@JotaBe Yeah that's what I did. Thanks :)

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.