java socket DataInputStream

Question

I have a multithreaded program java java socket and I receive the information bizare. like this ¤¤¤¤¤¤23456718900263678722¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤¤

public void run() 
       {
            try {

                byte[] bs = new byte[64];

                 // read data into buffer
                 dataReception.read(bs);

                 // for each byte in the buffer
                 for (byte b:bs)
                 {
                    // convert byte into character
                    char c = (char)b;

                    // print the character
                    System.out.print(c);
                 }
            } catch (IOException e) {
                // TODO Auto-generated catch block
                e.printStackTrace();
            }
        }

Please add some info, how it should work, beacuse no one knows what you need. — Krzysztof Cichocki
– Krzysztof Cichocki, Commented May 27, 2015 at 10:45
I receives a stream DataInput and I want to convert has valid data but for now I receive special carractère — chems eddine el garrai
– chems eddine el garrai, Commented May 27, 2015 at 11:19
@chemseddineelgarrai Never provide additional information in comments. Always update your question accordingly. — GhostCat
– GhostCat, Commented May 27, 2015 at 11:34

GhostCat · Accepted Answer · 2015-05-27 12:32:23Z

3

The problem is here:

// read data into buffer
dataReception.read(bs);

Read doesn't read exactly that amount of bytes that you want to have in that array. It can read any number of bytes. Therefore you always have to check the return value of the read operation; and only when all expected bytes were read ... you should continue!

The reason that your output looks like garbage is this not that you would be receiving special characters.

What happens is:

You create a new array (which is initialized with zeros values).
Then you read some bytes, most likely, not enough bytes to fill that array.
After the first read, you print that array that now contains the initial zero values; and some bytes that resemble printable characters.

This can be verified by printing your array before reading. You will see that only contains those "special" characters.

edited May 27, 2015 at 12:32

answered May 27, 2015 at 10:47

GhostCat

141k28 gold badges190 silver badges262 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

user207421 Over a year ago

A new byte array is always initialised to zeros.

GhostCat Over a year ago

@EJP Is that true also for local variables? See the comments on stackoverflow.com/questions/3426843/…

user207421 Over a year ago

It is true for every array of primitives. 'Local variable' doesn't come into it. The array is always on the heap. Similarly, arrays of objects are always initialized to nulls.

GhostCat Over a year ago

@EJP Interestingly enough; my intuition was "an array should be all 0"; but I had a shroud of cloud; so I turned to SO ... instead of running the code myself. Thanks for your correction.

user207421 · Accepted Answer · 2015-05-27 11:56:49Z

1

If you're expecting exactly 64 byes, use readFully() instead of read(), or at least take some notice of its return value.

answered May 27, 2015 at 11:56

user207421

312k45 gold badges324 silver badges493 bronze badges

Comments

Krzysztof Cichocki · Accepted Answer · 2015-05-27 11:22:17Z

0

Try:

public void run() 
       {
            try {

                byte[] bs = new byte[64];

                 // read data into buffer
                 int readed = dataReception.read(bs);

                 // for each byte in the buffer
                 for (int n=0; n<readed;n++)

                 {
                    byte b=bs[n];

                    // convert byte into character
                    char c = (char)b;

                    // print the character
                    System.out.print(c);
                 }
            } catch (IOException e) {
                // TODO Auto-generated catch block
                e.printStackTrace();
            }
        }

answered May 27, 2015 at 11:22

Krzysztof Cichocki

6,4421 gold badge20 silver badges33 bronze badges

Comments

krishna T · Accepted Answer · 2019-12-05 13:43:07Z

0

DataInputStream is usually used when textual information need to be shared over socket. Use DataInputStream.readUTF() method if the transferred data is sent using DataOutputStream.writeUTF(String str) from the other end. DataInputStream and DataOutputStream sends two byte(unsigned) length of data before sending actual data.

final String data = din.readUTF();

answered Dec 5, 2019 at 13:43

krishna T

4164 silver badges14 bronze badges

Collectives™ on Stack Overflow

java socket DataInputStream

4 Answers 4

4 Comments

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related