Comparing Strings in Bash with Logical Or

Question

I'm having an issue getting a a simple y/n question to work. Consider the following code:

 echo "Hi there"
 read ans
 if [[ $ans != "y" || $ans != "Y" || $ans != "YES" || $ans != "yes" ]]; then
      echo "Foo"
      exit 0
 fi

I've looked at – I would argue – some of the more informative answers on StackOverflow for advice: Simple logical operators in Bash

I've tried all different types of variations such as:

if [[ ($ans != "y" || $ans != "Y" || $ans != "YES" || $ans != "yes") ]]; then
    echo "Foo"
    exit 0
fi

if [[ ($ans != "y*" || $ans != "Y*" || $ans != "YES*" || $ans != "yes*") ]]; then
    echo "Foo"
    exit 0
fi

if [[ ($ans != "y") || ($ans != "Y") || ($ans != "YES") || ($ans != "yes") ]]; then
    echo "Foo"
    exit 0
fi

Regardless of why I type in any of these cases, it automatically fails and I'm not sure why. If anyone has a better way to handle y/n answers then please let me know! Ideally I would like to use pattern matching (like I might do with Perl) but I'm not entirely sure the best way/most efficient way to accomplish a simple y/n question.

ooga · Accepted Answer · 2014-05-26 19:17:43Z

3

You need to use && instead of ||. As it stands you're saying if it's not equal to any of those possibilities, then execute the "then" block. You mean to say if it's not equal to all of them, then execute the "then" block. That requires &&.

answered May 26, 2014 at 19:17

ooga

15.6k2 gold badges23 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

djthoms Over a year ago

Face palm... It must be something between too late or too early. I'll make this as the answer when SO allows me to

Diego Torres Milano · Accepted Answer · 2014-05-26 19:22:07Z

3

You can use:

echo "Hi there"
read ans
case "$ans" in
    y|Y|YES|yes)
        ;;

    *)
      echo "Foo"
      exit 0
      ;;
esac

answered May 26, 2014 at 19:22

Diego Torres Milano

69.9k9 gold badges116 silver badges145 bronze badges

1 Comment

djthoms Over a year ago

Good but I only need to address a single case.

John1024 · Accepted Answer · 2014-05-26 19:36:06Z

2

The logic needs to be adjusted:

echo "Hi there"
read ans
if ! [[ "$ans" == "y" || "$ans" == "Y" || "$ans" == "YES" || "$ans" == "yes" ]]; then
     echo "Foo"  # User answered no
     exit 0
fi

The will echo "Foo" only if the answer was not one of "y", "Y" or "YES". By contrast, consider the original logic:

[[ $ans != "y" || $ans != "Y" || $ans != "YES" || $ans != "yes" ]]

At least one of these tests will be true regardless of what the user's answer is.

Using the `case` statement

You might consider using the case statement to analyze the user's answer:

read -p "Hi there: " ans
case "$ans" in
    [yY]*) ;;
    [nN]*) echo "Foo" ; exit 0 ;;
    *) echo "You were supposed to answer yes or no" ;;
esac

edited May 26, 2014 at 19:36

answered May 26, 2014 at 19:20

John1024

115k15 gold badges151 silver badges183 bronze badges

Comments

Vytenis Bivainis · Accepted Answer · 2014-05-26 19:16:05Z

0

Try read ans, not read $ans.

answered May 26, 2014 at 19:16

Vytenis Bivainis

2,38622 silver badges29 bronze badges

1 Comment

djthoms Over a year ago

My bad, it's correct in my script but not on here. I'll change that

Collectives™ on Stack Overflow

Comparing Strings in Bash with Logical Or

4 Answers 4

1 Comment

1 Comment

Using the `case` statement

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

Using the case statement

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related

Using the `case` statement