Null check throws NullReferenceException

Question

I have a simple line

if (currentClip.DynamicSpeed != null)

Where currentClip is my own datatype and DynamicSpeed is a custom type with few string and float variables.

In this case, currentClip is the object and says the DynamicSpeed is null. However, I still get a NullReferenceException from this line. Furthermore, it looks like the stack trace points to correct lines and all that in terms of where the exception comes from (some solutions suggested that they could be wrong and there were other solutions).

What could possibly cause this. There are no overloads to the != operator either.

[edit] Here are the relevant classes.

public class Clip2D
{
    public string Name;

    [ContentSerializer(Optional = true)]
    public bool FlipX;
    [ContentSerializer(Optional = true)]
    public bool FlipY;

    [ContentSerializer(Optional = true)]
    public string NextClip;

    [ContentSerializer(Optional = true)]
    public string PreviousClip;

    [ContentSerializer(Optional = true)]
    public DynamicSpeed DynamicSpeed;
}

public class DynamicSpeed
{
    public string AffectingVariable;

    public float MinSpeed;
    public float MaxSpeed;
    public float MinValue;
    public float MaxValue;
}

Should be noted that it doesn't ALWAYS throw it.

Have you checked to make sure currentClip is not also null? — JAB
– JAB, Commented Apr 29, 2014 at 16:19
Try if (currentClip != null && currentClip.DynamicSpeed != null) — Anthony Chu
– Anthony Chu, Commented Apr 29, 2014 at 16:20
The debugger shows currentClip is not null, it has it's other fields populated and DynamicSpeed is the only null field. — Muhwu
– Muhwu, Commented Apr 29, 2014 at 16:20
Possible duplicate of What is a NullReferenceException and how do I fix it? — Nasreddine
– Nasreddine, Commented Oct 4, 2015 at 9:09

kemiller2002 · Accepted Answer · 2014-04-29 16:20:26Z

3

Simple solution:

if (currentClip != null && currentClip.DynamicSpeed != null)

if currentClip is null, it wont check the second part of the conditional due to short circuiting.

answered Apr 29, 2014 at 16:20

kemiller2002

116k28 gold badges201 silver badges255 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

kemiller2002 Over a year ago

Can you post the class layout for currentclip?

Muhwu Over a year ago

Posted to original post.

Hoots · Accepted Answer · 2014-04-30 15:29:09Z

0

When it tries to evaluate

currentClip.DynamicSpeed

currentClip is likely to be null causing the exception.

answered Apr 30, 2014 at 15:29

Hoots

1,9961 gold badge15 silver badges24 bronze badges

Collectives™ on Stack Overflow

Null check throws NullReferenceException

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related