Why is my PHP function not returning a value?

Question

This function is meant to sanitise a given value but instead it outputs "n-a" as if no value was specified. It has to be the simplest issue but right this moment it has me beat.

function slug($text){ 

  // replace non letter or digits by -
  $text = preg_replace('~[^pLd]+~u', '-', $text);

  // trim
  $text = trim($text, '-');

  // transliterate
  $text = iconv('utf-8', 'us-ascii//TRANSLIT', $text);

  // lowercase
  $text = strtolower($text);

  // remove unwanted characters
  $text = preg_replace('~[^-w]+~', '', $text);

  if (empty($text))
  {
    return 'n-a';
  }

  return $text;
}

I'd appreciate some input.

Where does it become empty? Have you tried dumping the variable as you go along? (after replace, after trim, after strtolower, after second replace) — h2ooooooo
– h2ooooooo, Commented Apr 9, 2014 at 9:26
$text = preg_replace('~[^-w]+~', '', $text); this removes everything other than - and w. I think your string does not have - or w. so you are getting empty string. try to rewrite regex here — krishna
– krishna, Commented Apr 9, 2014 at 9:37

Rikesh · Accepted Answer · 2014-04-09 09:30:17Z

2

You need to change your first regex which seems to be incorrect, should be,

// replace non letter or digits by -
$text = preg_replace('~[^\w\d]+~u', '-', $text);

Working Demo.

answered Apr 9, 2014 at 9:30

Rikesh

26.5k14 gold badges82 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

h2ooooooo Over a year ago

I think he meant \pL\d (aka. unicode letter/digit).

0x1801ce Over a year ago

@h2ooooooo - adding backslashes solved my problem i.e. first regex to \pL\d and the second to \w

Prashant · Accepted Answer · 2014-04-09 09:27:48Z

1

Try using mb_string library instead of iconv. Its a better library.
At each instance try var_dump or echo to make sure the return of the data.

answered Apr 9, 2014 at 9:27

Prashant

2,0653 gold badges17 silver badges25 bronze badges

Collectives™ on Stack Overflow

Why is my PHP function not returning a value?

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related