How to modify multiple objects in the same OOP class?

Question

I have created a program from my textbook that deals with animals or Critters(). At the moment it deals with only a single critter.

The problem is now the textbook has asked me to create multiple critters, and instead of the functions working on a single critter, the functions should instead work on all of the critters.

I have zero idea how to do this.

So, how can I pass arguments to the multiple critters?

Here's my attempt (code snippet):

Traceback (most recent call last):
  File "C:\pcrit.py", line 76, in main
    animal.eat(units)
AttributeError: 'str' object has no attribute 'eat'

^error^

import random

class Critter(object):
    """A virtual pet."""
    def __init__(self,name):
        self.name = name
        self.boredom = random.randrange(0,30)
        self.hunger = random.randrange(0,30)
        print "A new critter is born:", self.name, "\n"

    def eat(self, food):
        food = int(food)
        self.hunger -= food
        if self.hunger < 0:
            self.hunger = 0

# main

critters = ["donkey","monkey","dog","horse"]
# make each animal into the Critter() class
for animal in critters:
    animal = Critter(animal)

units = (raw_input("How many play units? "))
for animal in critters:
    animal.eat(units)

jonrsharpe · Accepted Answer · 2014-03-07 17:09:18Z

1

You are iterating through

critters = ["donkey","monkey","dog","horse"]

Those are strings, they don't have methods like eat.

Instead, you need to make a list of Critters

critters = [Critter(name) for name in ["donkey", "monkey", "dog", "horse"]]

What you are doing:

for animal in critters:
    animal = Critter(animal)

Doesn't assign the new objects back to the list critters.

edited Mar 7, 2014 at 17:09

answered Mar 7, 2014 at 16:44

jonrsharpe

123k31 gold badges277 silver badges488 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

BBedit Over a year ago

I don't understand why iterating through the list doesn't work. It works manually if I type donkey.eat(units)

jonrsharpe Over a year ago

@user2071506 yes, but you aren't putting the Critter instance back into the list, so you always iterate over the strings.

jonrsharpe Over a year ago

@JonClements where would I be without you!

Jon Clements Over a year ago

@jonrsharpe someone said that earlier in Python chat :)... my response remains the same - "you'd be left in peace" :p

BBedit Over a year ago

@jonrsharpe Oh, I think I understand... So you mean the For loop is literally doing this: "donkey".eat(units)? I don't fully understand the code in your answer, so I'm trying to work it out in my head more for an easier solution.

|

Collectives™ on Stack Overflow

How to modify multiple objects in the same OOP class?

1 Answer 1

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related