Why does the output keep repeating?

Question

I am tryng to make a simple counter that counts the number of times a character is present in a string, but I'm doing something wrong. When i try to print the counter it repeats a number of times.

import java.util.Scanner;

public class Uppgift5 {

public static void main(String[] args) {

    int counter = 0;

    Scanner scanner = new Scanner(System.in);

    System.out.println("What string do you want to search: ");
    String string = scanner.nextLine();

    System.out.println("What letter do you want to count? ");
    String letter = scanner.nextLine();


    for(int i=0; i<string.length(); i++ ) {
        if (string.charAt(i) == letter.charAt(0)){
            counter++; 
        }

        System.out.println("This string has " + counter + " " + letter);

    }
}
}

Konstantin Yovkov · Accepted Answer · 2013-11-21 11:43:44Z

6

Place the

System.out.println("This string has " + counter + " " + letter);

outside of the loop and you're done.

answered Nov 21, 2013 at 11:43

Konstantin Yovkov

63k9 gold badges107 silver badges152 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Rakesh KR · Accepted Answer · 2013-11-21 11:44:40Z

1

Place System.out.println("This string has " + counter + " " + letter); outside the for loop

answered Nov 21, 2013 at 11:44

Rakesh KR

6,5475 gold badges45 silver badges58 bronze badges

Comments

Mogana · Accepted Answer · 2013-11-21 11:47:50Z

0

The code should be...

int counter = 0;

Scanner scanner = new Scanner(System.in);

System.out.println("What string do you want to search: ");
String string = scanner.nextLine();

System.out.println("What letter do you want to count? ");
String letter = scanner.nextLine();


for(int i=0; i<string.length(); i++ ) {
    if (string.charAt(i) == letter.charAt(0)){
        counter++; 
    }

 }

System.out.println("This string has " + counter + " " + letter);

answered Nov 21, 2013 at 11:47

Mogana

2621 gold badge4 silver badges14 bronze badges

Collectives™ on Stack Overflow

Why does the output keep repeating?

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related