function problems in PHP

Question

I searched and searched and couldnt find any answer to my question So I'm sorry if this is a repost newbie here.

I have this function in a separate file called functions.php

function get_all_posts(){
global $connection;
$q = "SELECT * FROM blog LIMIT 1";
$get_posts = mysqli_query($connection, $q);
if (!$get_posts){
    die ('Query failed.');
}
return $get_posts;
}

And a called to function in blog.php

<div class="group">
        <?php get_all_posts();
            while ($row = mysqli_fetch_array($get_posts)){
         ?>
         <h1><?php echo $row['title']; ?></h1>
         <?php } ?>
        </form>
    </div>

But I keep having an undifined variable $get_posts.

Orangepill · Accepted Answer · 2013-07-08 21:55:39Z

1

You have to assign the results of get_all_posts to $get_posts;

<?php $get_posts = get_all_posts(); 
while ($row = mysqli_fetch_array($get_posts)){
     ?>
     <h1><?php echo $row['title']; ?></h1>
     <?php } ?>
    </form>
</div>

answered Jul 8, 2013 at 21:55

Orangepill

24.7k3 gold badges44 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pablito Diaz Over a year ago

Thank you very much!, I've been all morning trying to figure this out!

Marc B · Accepted Answer · 2013-07-08 21:55:35Z

1

You don't capture the returned value. e.g. you should have

$get_posts = get_all_posts();

If you don't assign the return value of a function to a variable, that return value is thrown away. So your query was basically useless.

answered Jul 8, 2013 at 21:55

Marc B

362k44 gold badges433 silver badges508 bronze badges

Comments

SamHuckaby · Accepted Answer · 2013-07-08 21:56:54Z

0

Change the code in your blog.php to something like this:

<div class="group">
    <?php 
        $get_posts = get_all_posts();
        while ($row = mysqli_fetch_array($get_posts))
        {
     ?>
     <h1><?php echo $row['title']; ?></h1>
     <?php 
        }
     ?>
    </form>
</div>

Your function returns a value, but it doesn't pass it straight out. You have to capture it in a variable like so $newvariable = function(); and then you can use $newvariable wherever you want.

answered Jul 8, 2013 at 21:56

SamHuckaby

1,1621 gold badge14 silver badges35 bronze badges

Comments

vicosoft · Accepted Answer · 2013-07-08 22:09:57Z

0

Sure! In order for you not to get undefined variable, you must assign value to your variable, in this scenario $get_posts, before using it in mysqli_fetch_array() function. The code Orangepill suggested will definitely work.

answered Jul 8, 2013 at 22:09

vicosoft

731 silver badge10 bronze badges

Collectives™ on Stack Overflow

function problems in PHP

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related