Symfony 2.2 extend ExceptionController

Question

This question is related to the following change (part of Symfony 2.2 release):

Part 1

In pre-2.2 Symfony, I was overriding ExceptionController to display some custom error pages.

I did that via:

parameters:
       twig.exception_listener.controller: My\CustomBundle\CustomExceptionController::showAction

Now, after upgrading to 2.2, I can no longer do that, because an exception is thrown while generating an exception (no pun intended):

ExceptionController::__construct() must be an instance of Twig_Environment, none given, called in...

Since ExceptionController is a service now, how can I override that, and what do I need to change in my old code?

All I did in the custom class, is changed the template reference in showAction method:

$template = new TemplateReference('TwigBundle', 'Exception', $name, $format, 'twig');

Part 2

Since ExceptionController no longer extends ContainerAware, how do I get to the current container? Is it enough to implement ContainerAwareInterface?

Darragh Enright · Accepted Answer · 2015-07-08 09:27:17Z

12

You should change a couple of this:

you need to inherit the ExceptionController in your custom Exception controller.
you need to override the twig.controller.exception.class parameter. As you can see in the service file, it uses the twig.controller.exception.class parameter to identify the exception controller class. Now override it with your class:
```
parameters:
    twig.controller.exception.class: My\CustomBundle\CustomExceptionController
```
you need to edit the signature of the showAction to follow the new signature

Since ExceptionController no longer extends ContainerAware, how do I get to the current container? Is it enough to implement ContainerAwareInterface?

No, services shouldn't never inject the container. You should inject the services you need in the constructor, as is done with the Twig_Environment service.

Inside your Exception controller, you get access to the $this->twig property for the twig service. And the new signature gets a $request parameter, to get the request. I don't think you need more. (you also get $this->debug)

edited Jul 8, 2015 at 9:27

Darragh Enright

14.2k8 gold badges45 silver badges49 bronze badges

answered Apr 2, 2013 at 20:40

Wouter J

42k15 gold badges113 silver badges114 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

isyndicate Over a year ago

Thanks Wouter! What I was missing is the twig.controller.exception.class override. Works like a charm now.

isyndicate Over a year ago

Actually for the 2nd part of my question, in the previous implementation of ExceptionController, I was able to retrieve parameter from $this->container->getParameter(). How can I retrieve that same parameter in the new custom exception controller, now that it's a service? Is using $this->twig->getGlobals() would be the right way to go?

shakaran Over a year ago

I found this tutorial useful too: knpuniversity.com/screencast/symfony2-ep3/error-pages

Francesco Borzi Over a year ago

I'm getting the same error, I'm following this using Symfony 3.2.0-DEV and I'm already inheriting from ExceptionController.. How can I solve?

Collectives™ on Stack Overflow

Symfony 2.2 extend ExceptionController

1 Answer 1

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related