Help with simple C# error

Question

I'm writing this small program to extract any number of email address from a text file. I am getting two errors, "Use of unassigned local variable." and I'm not sure why.

static void Main(string[] args)
{
string InputPath = @"C:\Temp\excel.txt";
string OutputPath = @"C:\Temp\emails.txt";
string EmailRegex = @"^(?:[a-zA-Z0-9_'^&amp;/+-])+(?:\.(?:[a-zA-Z0-9_'^&amp;/+-])+)*@(?:(?:\[?(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?))\.){3}(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\]?)|(?:[a-zA-Z0-9-]+\.)+(?:[a-zA-Z]){2,}\.?)$";
string Text = String.Empty;
StringBuilder Output;
List<string> Emails;

using (TextReader tr = new StreamReader(InputPath))
{
    Text = tr.ReadToEnd();
}

MatchCollection Matches = Regex.Matches(Text,EmailRegex);

foreach (Match m in Matches)
{
    Emails.Add(m.ToString().Trim()); // one error is here
}

foreach (String s in Emails)
{
    Output.Append(s + ","); // the other error is here
}

using (TextWriter tw = new StreamWriter(OutputPath))
{
    tw.Write(Output.ToString());
}
}

Sorry for the formatting ... I'm kind of pressed for time!

edit: WOW. I'm an idiot - must be because I'm pressed for time!!!!

Dave Markle · Accepted Answer · 2009-07-17 13:08:46Z

21

You aren't initializing the StringBuilder and List.

StringBuilder Output = new StringBuilder();
List<string> Emails = new List<String>();

answered Jul 17, 2009 at 13:08

Dave Markle

98.3k20 gold badges152 silver badges172 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

lavinio · Accepted Answer · 2009-07-17 13:09:05Z

9

The problem is here:

StringBuilder Output;
List<string> Emails;

You haven't initialized Emails and Output. Try:

StringBuilder Output = new StringBuilder();
List<string> Emails = new List<string>();

answered Jul 17, 2009 at 13:09

lavinio

24.4k5 gold badges57 silver badges72 bronze badges

Comments

d4nt · Accepted Answer · 2009-07-17 13:10:07Z

8

Your "Output" and "List" variables are not assigned with object instances. Change:

StringBuilder Output;
List<string> Emails;

To

StringBuilder Output = new StringBuilder();
List<string> Emails = new List<string>();

answered Jul 17, 2009 at 13:10

d4nt

15.8k9 gold badges46 silver badges52 bronze badges

Comments

Dave Markle · Accepted Answer · 2009-07-17 13:15:13Z

8

you are not creating a Stringbuilder or Email List:

StringBuilder Output = new StringBuilder();
List<string> Emails = new List<string>();

edited Jul 17, 2009 at 13:15

Dave Markle

98.3k20 gold badges152 silver badges172 bronze badges

answered Jul 17, 2009 at 13:09

Mitch Wheat

302k44 gold badges482 silver badges552 bronze badges

Comments

Zensar · Accepted Answer · 2009-07-17 13:15:37Z

4

You have to initialize the Emails and Output objects by using "new". Basically have:

StringBuilder Output = new StringBuilder();
List<string> Emails = new List<string>();

answered Jul 17, 2009 at 13:15

Zensar

8174 silver badges8 bronze badges

Comments

Guffa · Accepted Answer · 2009-07-17 13:26:27Z

As so many have said, the errors come from the object that you didn't create.

But, why are you storing the email addresses in a temporary list, then putting them in a temporary string, then write it to a file? Just write them to the file directly:

static void Main(string[] args) {

   string InputPath = @"C:\Temp\excel.txt";
   string OutputPath = @"C:\Temp\emails.txt";
   string EmailRegex = @"^(?:[a-zA-Z0-9_'^&amp;/+-])+(?:\.(?:[a-zA-Z0-9_'^&amp;/+-])+)*@(?:(?:\[?(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?))\.){3}(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\]?)|(?:[a-zA-Z0-9-]+\.)+(?:[a-zA-Z]){2,}\.?)$";

   using (TextWriter tw = new StreamWriter(OutputPath))
      foreach (Match m in Regex.Matches(File.ReadAllText(InputPath), EmailRegex)) {
         tw.Write(m.Value);
         tw.Write(',');
      }
   }
}

Note: The regular expression seems to have been corrupted somewhere along the line. There are some & in it that probably should just be & characters.

Collectives™ on Stack Overflow

Help with simple C# error

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

Comments

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related