Accessing variables in another script

Question

I have a JS

function check(obj) {

for( i=0; i<obj.elements.length; i++){
    if(obj.elements[i].type=="checkbox"&&obj.elements[i].checked){
        if(confirm(onSubmitMessage)){
            return true;
        }
        else{
            return false;
        }
    }
}
alert(alertMessage);
return false;
}

It's called from jsp page like this:

<script src="/TestAppChanged/check.js" type="text/javascript">
    var onSubmitMessage = '"<bean:message key="body.onsubmit.delete"/>"';
    var alertMessage = '"<bean:message key="body.alert.delete"/>"';
</script>
...
<form action="MyAction" method="POST"
onsubmit="return check(this)">

The problem is in that it doesn't see these glabal variables: onSubmitMessage and alertMessage. I thought that the problem was in the way that these things are set and changed it's values to usual strings like "qwe" but it didn't work again. So script in it's body simply doesn't see these variables. And the question is how to get them from script?

Romain Linsolas · Accepted Answer · 2012-05-31 20:12:12Z

3

The <script> tag is used either to load an external file, like <script src="path/to/file.js"></script> or to define JS code inside the tag, like:

<script type="text/javascript">
    // Your JS code.
</script>

You can't have both on the same tag. Thus, split your code:

<script src="/TestAppChanged/check.js" type="text/javascript"></script>
<script type="text/javascript">
    var onSubmitMessage = '"<bean:message key="body.onsubmit.delete"/>"';
    var alertMessage = '"<bean:message key="body.alert.delete"/>"';
</script>

edited May 31, 2012 at 20:12

answered May 31, 2012 at 19:59

Romain Linsolas

82.1k52 gold badges207 silver badges277 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ortiga Over a year ago

I think you meant "You can't have both on the same tag"... ;)

Pethical · Accepted Answer · 2012-05-31 19:59:19Z

2

A block between <script src=""></script> parsed when the browser don't support javascript. You need another <script> block, and put in this your variables.

answered May 31, 2012 at 19:59

Pethical

1,49211 silver badges18 bronze badges

Comments

Daniele B · Accepted Answer · 2012-05-31 19:58:47Z

1

It doesn't see the globar variabes because you declare a source in the script tag. You should remove the global variables and declare them before the code of the function, in the js page, and then simply include the page like this:

<script src="/TestAppChanged/check.js" type="text/javascript"></script>

answered May 31, 2012 at 19:58

Daniele B

3,1352 gold badges25 silver badges46 bronze badges

Comments

Seth Flowers · Accepted Answer · 2012-05-31 19:58:53Z

1

You should have two script tags. One for the variables. And then another one below it, linking to your javascript file.

answered May 31, 2012 at 19:58

Seth Flowers

9,2302 gold badges34 silver badges46 bronze badges

Comments

Marius Balčytis · Accepted Answer · 2012-05-31 19:59:34Z

1

You can set contents in tag OR set the src attribute. It should be:

<script type="text/javascript">
    var onSubmitMessage = '"<bean:message key="body.onsubmit.delete"/>"';
    var alertMessage = '"<bean:message key="body.alert.delete"/>"';
</script>
<script src="/TestAppChanged/check.js" type="text/javascript"></script>

answered May 31, 2012 at 19:59

Marius Balčytis

2,66122 silver badges23 bronze badges

Comments

Jeff Watkins · Accepted Answer · 2012-05-31 20:00:23Z

1

Don't mix the src attribute and code within the tag. Use two tags.

answered May 31, 2012 at 20:00

Jeff Watkins

6,35718 silver badges19 bronze badges

Collectives™ on Stack Overflow

Accessing variables in another script

6 Answers 6

1 Comment

Comments

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

6 Answers 6

1 Comment

Comments

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related