PHP variable scope confused

Question

Hello
Here is my code.... THe problem is at $product variable.
Is there any way to fix this?
It is defined two times and causes problem overwrites

THE PROBLEM UPDATED

   $productsIDs = array();
        foreach ($rowsProducts as &$product) {
            $product["features"] = &$productsFeatures[$product["product_id"]];
            $productsIDs[] = $product["product_id"];
        }

//GET STOCK FEATURES
$sqlIds=implode(",",$productsIDs);
$sql="SELECT * FROM eshop_products_stock WHERE product_id IN ($sqlIds)";

$productsStock = $db->getRecordSet($sql);
$sql="SELECT * FROM `eshop_features_valuestr` WHERE feature_id IN ".
      "(SELECT DISTINCT feature1_id FROM eshop_products_stock WHERE product_id IN ($sqlIds))" .
        " AND language_code='$lang'";

$productsSizes = $db->getRecordSet($sql);
 $sql="SELECT * FROM `eshop_features_valuestr` WHERE feature_id IN ".
      "(SELECT DISTINCT feature2_id FROM eshop_products_stock WHERE product_id IN ($sqlIds))".
        " AND language_code='$lang'";;
$productsColors = $db->getRecordSet($sql);

$productsSizesV=array();
foreach($productsSizes as $size)
{
    $productsSizesV[$size["value"]]=$size["title"];
}

$productsColorsV=array();
foreach($productsColors as $color)
{
    $productsColorsV[$color["value"]]=$color["title"];
}
//Group by product stock
$productsStockV=array();
$product="";

foreach($productsStock as $product)
{
   $productsStockV[$product["product_id"]]["sizes"][]=$product["feature1_value"];
   $productsStockV[$product["product_id"]]["colors"][]=$product["feature2_value"];
}

There's no need to "declare" $product before the foreach loop; you should remove the line $product="" as it only confuses things. — user229044
– user229044 ♦, Commented Nov 14, 2010 at 18:37

codaddict · Accepted Answer · 2010-11-14 19:20:19Z

4

You should unset $product after the foreach loop:

foreach ($rowsProducts as &$product) {
      $product["features"] = &$productsFeatures[$product["product_id"]];
      $productsIDs[] = $product["product_id"];
}
unset($product);

answered Nov 14, 2010 at 19:20

codaddict

457k83 gold badges501 silver badges537 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

ThiefMaster · Accepted Answer · 2010-11-14 19:21:05Z

3

You've encountered a very nice php WTF: foreach ($rowsProducts as &$product) makes $product a reference. Not only for the loop but forever. If you then use a foreach using $product as the loop variable later (or do anything writing to $product), it will overwrite the last item of the first foreach loop.

Simply use foreach ($rowsProducts as $key => $product) and assign $rowsProducts[$key] = $product; at the end of your loop body if you changed anything.

Another solution would be calling unset($product); after your first loop to get rid of the reference. But generally not using reference loops is safer as you cannot forget to unset.

answered Nov 14, 2010 at 19:21

ThiefMaster

320k85 gold badges608 silver badges648 bronze badges

Collectives™ on Stack Overflow

PHP variable scope confused

THE PROBLEM UPDATED

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

THE PROBLEM UPDATED

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related