PHP variable scope help

Question

require_once('classes/class.validation.php');

$array = $_POST['array'];
$pass_profanity = false;
$validation = new Validation;
function check_for_profanity($input){
    if(is_array($input)){
        foreach($input as $row){
            if(is_array($row)){
                check_for_profanity($input);
            } else {
                $pass_profanity = $validation->check_for_profanity($row);
            }
        }
    } else {
        $pass_profanity = $validation->check_for_profanity($input);
        return;
    }
    return;
}
check_for_profanity($array);

But I get the error:

Notice: Undefined variable: validation in /Library/WebServer/Documents/file.php on line 22

Fatal error: Call to a member function check_for_profanity() on a non-object in /Library/WebServer/Documents/file.php on line 2

I can't figure it out, any thoughts???

Thanks in advance!

Define $validation in your function, check_for_profanity. — Josh
– Josh, Commented Jul 14, 2011 at 10:26

Sascha Galley · Accepted Answer · 2011-07-14 10:25:29Z

2

You can either gain access to the variable in your function with global:

function check_for_profanity($input){
    global $validation;
    ...
}

Or, the better way would be to retrieve it via a parameter:

function check_for_profanity($input, $validation){
    ...
}

check_for_profanity($array, $validation);

Read the PHP manual - variable scope for more information

answered Jul 14, 2011 at 10:25

Sascha Galley

16.2k5 gold badges39 silver badges52 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Brendan Bullen Over a year ago

@FraserK Which of the two approaches did you go with from Sascha's answer?

Bart S. · Accepted Answer · 2011-07-14 10:23:55Z

1

You're defineing $validation = new Validation; outside of the function. Therefore PHP doesn't know it exists.

answered Jul 14, 2011 at 10:23

Bart S.

11.5k1 gold badge21 silver badges26 bronze badges

Comments

Brendan Bullen · Accepted Answer · 2011-07-14 10:24:55Z

1

Use the global keyword: PHP.net: Variable Scope

$validation = new Validation;
function check_for_profanity($input){

    global $validation;

    //The rest of your function
}

answered Jul 14, 2011 at 10:24

Brendan Bullen

11.8k1 gold badge33 silver badges40 bronze badges

3 Comments

FraserK Over a year ago

since this is a recursive function will it not be debilitating for the system memory if its being stated as global??

Brendan Bullen Over a year ago

@FraserK Honestly, I don't know. As far as I am aware, the global keyword essentially references the $GLOBALS array. The recursive nature of the function shouldn't have an impact since each call to the global keyword will cause the application to constantly reference the same object. However, I don't know that as a fact.

FraserK Over a year ago

okay :) i just realised that the level of recursion will not go that deep anyways :) so it should be fine

Collectives™ on Stack Overflow

PHP variable scope help

3 Answers 3

1 Comment

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related