C# calculate mean of the values in int array

Question

What's the problem when I try to print the average of the values in int array and it prints out something totally different as many times as I have values.

int[] numbers;
numbers = new int[5];
Console.WriteLine("give five integer numbers:");
numbers[0] = Int32.Parse(Console.ReadLine());
numbers[1] = Int32.Parse(Console.ReadLine());
numbers[2] = Int32.Parse(Console.ReadLine());
numbers[3] = Int32.Parse(Console.ReadLine());
numbers[4] = Int32.Parse(Console.ReadLine());
int sum = 0;

foreach (int x in numbers) {
    sum += x;
    int aver = sum / numbers.Length;  
    Console.WriteLine("average: {0}",aver);
}

To fix your code, move the int aver line outside the foreach loop. — Baldrick
– Baldrick, Commented Jun 22, 2016 at 11:43

Zein Makki · Accepted Answer · 2016-06-22 11:45:20Z

10

Average should be outside the loop:

foreach (int x in numbers) 
{
   sum += x;
}

int aver = sum / numbers.Length;  
Console.WriteLine("average: {0}",aver);

Or using Linq Extension Methods:

Console.WriteLine("average: {0}", numbers.Average());

edited Jun 22, 2016 at 11:45

answered Jun 22, 2016 at 11:42

Zein Makki

30.2k6 gold badges58 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Codor · Accepted Answer · 2016-09-14 07:22:28Z

5

You could rephrase the loops as

int sum = 0;
foreach (int x in numbers)
{
    sum += x;
}
int aver = sum / numbers.Length;

or simply do the calculation as

int aver = numbers.Average();

by using Linq.

edited Sep 14, 2016 at 7:22

answered Jun 22, 2016 at 11:43

Codor

17.6k9 gold badges32 silver badges59 bronze badges

1 Comment

Nayangar Over a year ago

I think it should be double aver = numbers.Average() regarding to Average() 's return type

Quentin Roger · Accepted Answer · 2016-06-22 12:15:36Z

3

Or with linq : var aver = numbers.Average();

https://msdn.microsoft.com/en-us/library/bb399409(v=vs.110).aspx

I ll complete my answer with what is the hood under Average() so ;)

  public static double Average(this IEnumerable<int> source) {
       if (source == null) throw Error.ArgumentNull("source");
       long sum = 0;
       long count = 0;
       checked {
          foreach (int v in source) {
              sum += v;
              count++;
          }
       }
       if (count > 0) return (double)sum / count;
       throw Error.NoElements();
   }

edited Jun 22, 2016 at 12:15

answered Jun 22, 2016 at 11:44

Quentin Roger

6,5482 gold badges26 silver badges37 bronze badges

1 Comment

C.Evenhuis Over a year ago

"Don't think, use linq" - is this really an answer?. Under the hood Linq does the foreach for you; there's nothing wrong with using Linq, but I hope the OP is also trying to understand the problem.

Mohammad Mirmostafa · Accepted Answer · 2016-06-22 11:43:19Z

0

Change

foreach (int x in numbers) {
    sum += x;
    int aver = sum / numbers.Length;  Console.WriteLine("average: {0}",aver);
}

To

foreach (int x in numbers) {
    sum += x;
}
int aver = sum / numbers.Length;  Console.WriteLine("average: {0}",aver);

answered Jun 22, 2016 at 11:43

Mohammad Mirmostafa

1,7752 gold badges16 silver badges34 bronze badges

Comments

Mehrdad · Accepted Answer · 2023-02-14 13:47:45Z

0

One of the best way and clean code for calculating average of array elements using below code:

int[] numbers = new int[5];
int sum = 0;
int average = 0;

Console.WriteLine("give five integer numbers:");

for(int i = 0; i < numbers.length; i++)
    numbers[i] = Int32.Parse(Console.ReadLine());

Array.ForEach(numbers, x => sum += x);
average = sum / numbers.Length;
Console.WriteLine("Average: {0}", average);

With Array.ForEach you can access to all of elements in Array and using any operand for it.

edited Feb 14, 2023 at 13:47

answered Feb 14, 2023 at 13:45

Mehrdad

112 bronze badges

Collectives™ on Stack Overflow

C# calculate mean of the values in int array

5 Answers 5

Comments

1 Comment

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related