Uploading a file in Java using a servlet

Question

I'm using javazoom for uploading

protected void processRequest(HttpServletRequest request, HttpServletResponse response)
throws ServletException {
    PrintWriter out = null;
    JOptionPane.showMessageDialog(null, "Lets do this");
    try {
        response.setContentType("text/html;charset=UTF-8");
        try {
            MultipartFormDataRequest dataRequest = new MultipartFormDataRequest(request);
            //get uploaded files
            Hashtable files = dataRequest.getFiles();
            if (!files.isEmpty()) {
                UploadFile uploadFile = (UploadFile) files.get("filename");
                byte[] bytes = uploadFile.getData();
                String s = new String(bytes);

the files are always coming as empty. Any help please?

I then tried doing this with Apache Commons FileUpload:

 protected void processRequest(HttpServletRequest request, HttpServletResponse response)
throws ServletException {
     PrintWriter out = null;

        try {

            response.setContentType("text/html;charset=UTF-8");
            //MultipartFormDataRequest dataRequest = new MultipartFormDataRequest(request);
            //get uploaded files
            FileItemFactory factory = new DiskFileItemFactory();
            // Create a new file upload handler
            ServletFileUpload upload = new ServletFileUpload(factory);
            List files = null;
            try {
                files = upload.parseRequest(request);
            } catch (FileUploadException ex) {
                Logger.getLogger(ProcessUploadItem.class.getName()).log(Level.SEVERE, null, ex);
            }

and it failed at files = upload.parseRequest(request);

Any pointers?

Sorry and thank you :)

Please pay attention to the suggest prompts when tagging your question. Any tag with a number less than 10 after it's name is probably wrong. Avoid creating new tags. — Joel Coehoorn
– Joel Coehoorn, Commented Jun 5, 2009 at 14:41

victor hugo · Accepted Answer · 2009-06-04 09:18:19Z

4

Check the form sending the file has enctype="multipart/form-data" defined like here:

<form enctype="multipart/form-data" action="...

Other way the file will never upload according to RFC1867

answered Jun 4, 2009 at 9:18

victor hugo

35.9k12 gold badges72 silver badges79 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Lilz Over a year ago

I wrote this to my other servlet out.println("<form action='ProcessUploadItem' method='post' enctype='multipart/form-data'>"); out.println("<h1>File upload</h1>"); out.println("Select a file:"); out.println("<input type='file' name='filename' />"); out.println("<br />"); out.println("<input type='submit' name='button' value='upload' />"); out.println("</form>");

skaffman · Accepted Answer · 2009-06-04 12:02:27Z

4

I'd recommend using a more popular, high-profile library to do this, such as Apache Commons FileUpload. It's more likely to work, have better docs and have more people around to help you use it.

answered Jun 4, 2009 at 12:02

skaffman

405k96 gold badges825 silver badges775 bronze badges

Comments

Pere Villega · Accepted Answer · 2009-06-04 10:43:23Z

0

Are you using another framework, like Trinidad or similar? They usually include filters that recover the uploaded files so when the process gets to your server, the request doesn't contain any attached file.

answered Jun 4, 2009 at 10:43

Pere Villega

16.4k5 gold badges66 silver badges100 bronze badges

1 Comment

Lilz Over a year ago

No, I don't believe that I am :S

Collectives™ on Stack Overflow

Uploading a file in Java using a servlet

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related