Javascript two-dimensional array

Question

I want to create a two dimensional array in a javascript function. I found code that should do that but doesn't. I declare the array then define a function to add elements to the array which are also arrays.

    // Array function
    var card_array = new Array();
    function card_array(card_id, card_top, card_left) {
        alert('array');
        this.card_id = card_id;
        this.card_top = card_top;
        this.card_left = card_left;
    }

    // Toggle LinkCard minimize/expand
    function toggle_linkcard(toggle, card_id) {

        var icard = 0; 
        $('.linkcard').each(function () {
            card_top = $(this).position().top;
            card_left = $(this).position().left;
            card_i = $(this).attr('id');
            card_array[card_array.length++] = new card_array(card_i, card_top, card_left);
            icard++;
        });
        alert(card_array);

    }

The line of code where I add elements to the array breaks the code.

            card_array[card_array.length++] = new card_array(card_i, card_top, card_left);

What should I fix in that?

melihcelik · Accepted Answer · 2011-11-18 15:55:25Z

2

You defined the function's name as card_array, same name as the variable's. So after that line of code, you don't have any variable named card_array, only the function. Try changing your variable or function name.

answered Nov 18, 2011 at 15:55

melihcelik

4,5991 gold badge23 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jonathan M Over a year ago

Also, you can eliminate some code clutter by doing a card_array.push() instead of card_array[card_array.length++].

JaredPar · Accepted Answer · 2011-11-18 15:56:31Z

2

The problem here is that you have two values with the same name: card_array

A variable named which is initialized to a new Array()
A function which takes 3 parameters

The function declaration happens last and hence wins. So when you execute the expression card_array[card_array.length++] you are doing so on a function instance, not an array.

To fix this change the function name to a unique name.

answered Nov 18, 2011 at 15:56

JaredPar

759k152 gold badges1.3k silver badges1.5k bronze badges

1 Comment

user823527 Over a year ago

That was the problem. Thanks.

Rodolphe · Accepted Answer · 2011-11-18 16:06:22Z

0

Just change this line:

var card_array = new Array();

into:

var my_card_array = new Array();

And this one:

card_array[card_array.length++] = new card_array(card_i, card_top, card_left);

into:

my_card_array.push(new card_array(card_i, card_top, card_left));

And of course, change the alert.

answered Nov 18, 2011 at 16:06

Rodolphe

1,7611 gold badge15 silver badges34 bronze badges

1 Comment

user823527 Over a year ago

Thanks. I changed the variable name and switched to .push(). This works.

Collectives™ on Stack Overflow

Javascript two-dimensional array

3 Answers 3

1 Comment

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related