Make a deep copy of an object inside a ConcurrentDictionary in C#

Question

This is a follow up question to my previous one, Deep copy a ConcurrentDictionary in C#, which did not contain sufficient information for it to be properly answered.

I am trying to make a deep copy of an object, Patient, in a ConcurrentDictionary, _baselinePatients, to another ConcurrentDictionary, _patientsCurrentArm, in C#, but failing. It seems as if the patient that I copy from _baselinePatients to _patientsCurrentArm is just a pointer, despite using MemberwiseClone when cloning the patient.

Does it have to do with the fact that the two ConcurrentDictionaries _baselinePatients and _patientsCurrentArm contain the same data types?

See my comment on line 47 in the code below where I get this error: System.ArgumentException: 'An item with the same key has already been added. Key: Covariate'

using System.Collections.Concurrent;
namespace ExampleCode;
internal class Program
{
    private static void Main(string[] args)
    {
        Exampel obj = new();
        obj.DoStuff();
    }
}

internal class Exampel()
{
    /// <summary>
    /// For the baseline patients (patient ID, patient object), same for all arms and only generated once
    /// </summary>
    private ConcurrentDictionary<int,
                                 Patient> _baselinePatients = new();

    /// <summary>
    /// Patients in the current arm (patient ID, patient object)
    /// </summary> 
    private ConcurrentDictionary<int,
                                 Patient> _patientsCurrentArm = new();

    public void DoStuff()
    {
        const int EXAMPLE_CYCLE = 0;
        // Set the number of arms and patients
        int _nArms = 2;
        int _nPatients = 5;

        // Add patients at baseline to _baselinePatients
        for (int i = 0; i < _nPatients; i++) {
            Patient patient = new Patient();
            patient.PatientCovariates.Add(0, new());
            _baselinePatients.TryAdd(i, patient);
        }

        // Try to copy the patients created in the baseline ConcurrentDictionary
        for (int i = 0; i < _nArms; i++) {
            for (int j = 0; j < _nPatients; j++) {
                Patient patObjCopy = (Patient)_baselinePatients[j].Clone();
                Patient patObjCopyTwo = (Patient)patObjCopy.Clone();

                // patObjCopy should not be the same as patObjCopyTwo
                // for i = 1 and j = 0 I get this error here: System.ArgumentException: 'An item with the same key has already been added. Key: Covariate'

                patObjCopy.PatientCovariates[EXAMPLE_CYCLE].Add("Covariate for patient ",    // To mark the arm name and make the patient struct different
                                                                j.ToString() + 
                                                                " in arm " + 
                                                                i.ToString());

                // Save the patient copy in the _patientsCurrentArm WITHOUT changing the patient in _baselinePatients
                _patientsCurrentArm.TryAdd(j, patObjCopy);
            }
        }

        // Print out the value of Covariate for the first and second patient in EXAMPLE_CYCLE 
        Console.WriteLine(_patientsCurrentArm[0].PatientCovariates[EXAMPLE_CYCLE]["Covariate"]);
        Console.WriteLine(_patientsCurrentArm[1].PatientCovariates[EXAMPLE_CYCLE]["Covariate"]);
    }

    internal struct Patient : ICloneable
    {
        /// <summary>
        /// Cycle, covariate name, covariate value
        /// </summary>
        public Dictionary<int,
                          Dictionary<string,
                                     string>> PatientCovariates
        { get; set; }


        /// <summary>
        /// Initiates PatientCovariates
        /// </summary>
        public Patient()
        {
            PatientCovariates = new();
        }

        /// <summary>
        /// Clone patients
        /// </summary>
        /// <returns></returns>
        public readonly object Clone()
        {
            Patient patient = (Patient)this.MemberwiseClone();
            return patient;
        }
    }
}

Serialise it to JSON. Then deserialise it. Tada. You have a deep clone. — mjwills
– mjwills, Commented Feb 20 at 22:21

Jeremy Richards · Accepted Answer · 2025-02-20 22:27:10Z

2

The issue has to do with how C# distinguishes Value Types and Reference Types. A reference type is always stored on the heap (if you are coming from C++ you can think of it as always a pointer). When you copy one (via the equal operator or memberwise clone) you are copying the value of the pointer, not making a deep copy of the object.

Value types are always the opposite -- copying one will clone the object itself. (There are more differences between value and reference types, but those are the most relevant to your question).

Here is one way you could clone your Dictionary:

    public readonly object Clone()
    {
       Patient patient = new() {
           PatientCovariates = this.PatientCovariates.ToDictionary(
               entry => entry.Key,
               entry => entry.Value.ToDictionary(
                   innerEntry => innerEntry.Key,
                   innerEntry => innerEntry.Value
               )
       )};
       return patient;
    }

Your call to Patient.MemberwiseClone() produces a copy of patient where the reference (pointer) to PatientCovariates has been copied, but the actual dictionary has not been copied.

If you want a unique and seperate copy of that dictionary you will need to write code in your Clone method to do so.

answered Feb 20 at 22:27

Jeremy Richards

1,2779 silver badges14 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

KGB91 Feb 20 at 22:40

Thanks a lot! That works fine. Yeah, I am coming from the C++ - I find it hard sometimes not working with pointers. If I want to copy something that is readonly in my patient object, say private readonly int _exampleNumber in the Clone method, how do I do that?

Jeremy Richards Feb 20 at 22:51

That may be worth a new question. You have a few options. Readonly is NOT the same as const in C++. You could create a private copy-like constructor (Patient constructor that takes a patient parameter) and then assign the readonly _exampleNumber there. (readonly means mutable until the constructor completes then immutable). Another option would be to use a version of the Patient constructor that sets your readonly variable and invoking that in the clone method. A final option would be to make it a private read/init property

KGB91 Feb 20 at 23:06

Thanks. Done: stackoverflow.com/questions/79456013/…

Collectives™ on Stack Overflow

Make a deep copy of an object inside a ConcurrentDictionary in C#

1 Answer 1

3 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related