Symfony2 : extending FrameworkBundle Controller

Question

I have a question about Symfony2 Controller extending. For the moment, I was always extending the FrameworkBundle one for every controller in my app. But I'm getting sick of always retrieving the user by making a

$this->get('security.context')->getToken()->getUser()

or a

$this->getDoctrine()->getEntityManager()

each time I need the user or the entity manager (I need them a lot). I wanted to be able to retrieve them just by doing $this->em and $this->user. So I decided to create a bundle named MyApp/RootBundle, which contains a new controller extending the FrameworkBundle one. This controller would be extended by every other controller in the app. Here is the code :

<?php

namespace MyApp\RootBundle\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\DependencyInjection\ContainerInterface;

class RootController extends Controller
{
    protected $em;

    protected $user;

    public function setContainer(ContainerInterface $container = null)
    {
        parent::setContainer($container);

        $this->onContainerSet();
    }

    public function onContainerSet()
    {
        $this->em = $this->getDoctrine()->getEntityManager();
        $this->user = $this->get('security.context')->getToken()->getUser();
    }
}

I couldn't load the $this->em and $this->user in a __construct() function since the container is not loaded at the construction time.

So my questions are :

Is that a good idea or should I continue to make the verbose calls ?
Would it be better to just create functions getEm() and getUser() that would do the same job ?

Thanks !

Steven Mercatante · Accepted Answer · 2011-10-10 21:46:50Z

4

I had the same problem, I just created a custom controller that had getUser() and getEntityManager() methods. It works perfectly. I would recommend using getter methods instead of class instances in this case just to keep consistent with how Symfony2 expects you to request services.

For reference, here is my getUser method:

public function getUser() {
        $user = $this->get('security.context')->getToken()->getUser();
        return $user;
}

answered Oct 10, 2011 at 21:46

Steven Mercatante

25.4k9 gold badges68 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Nanocom Over a year ago

Ok, that's what I thought. And is that a good idea to make a "RootBundle" or not ?

Steven Mercatante Over a year ago

You could, but I keep my custom controller in the vendor directory. I didn't see the need to put it in its own bundle. Either way should work fine though, so it comes down to personal preference.

Nicolas Zozol · Accepted Answer · 2011-10-13 13:12:24Z

0

I created a MyController but also a MyRepository. Then all Controllers and Repositories extends these classes. I also call $this->getRepository("User"), instead of $this->getDocrine()->getEntityManager()->getrepository("MyappBundle:User");

answered Oct 13, 2011 at 13:12

Nicolas Zozol

7,0784 gold badges55 silver badges75 bronze badges

2 Comments

Nanocom Over a year ago

Good idea, I'll do the same :)

Nicolas Zozol Over a year ago

Here is the snippet :

public function getEm(){         return $this->getDoctrine()->getEntityManager();     }          public function getRepository($shortEntityName){         return $this->getEm()->getRepository("SicoStockBundle:$shortEntityName");     }

mvrhov · Accepted Answer · 2011-10-12 10:06:07Z

0

Another option is that you define your controllers as services and assign what gets passed to your constructor to any private variable you wish, but the downside might be that you won't like all the setup this route needs

answered Oct 12, 2011 at 10:06

mvrhov

261 bronze badge

Comments

Evgeniy Kuzmin · Accepted Answer · 2015-04-06 20:48:31Z

0

you can inject EntityManager(or any other services) even without controller extantion as:

use JMS\DiExtraBundle\Annotation as DI;

    class IndexController extends Controller 
    {  
       /**
         * @DI\Inject("doctrine.orm.entity_manager")
         * @var \Doctrine\ORM\EntityManager $em
         */
        protected $em;

answered Apr 6, 2015 at 20:48

Evgeniy Kuzmin

2,4821 gold badge21 silver badges24 bronze badges

Collectives™ on Stack Overflow

Symfony2 : extending FrameworkBundle Controller

4 Answers 4

2 Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related