How to implement HashCode.Combine using SymbolEqualityComparer

Question

After updating packages to .net7 in roslyn code generation project, has error RS1024 Use 'SymbolEqualityComparer' when comparing symbols for IEqualityComparer implementation of GetHashCode()

public int GetHashCode([DisallowNull] TypeSymbolMetaType? obj) => System.HashCode.Combine(obj.TypeSymbol);

How to fix HashCode.Combine using SymbolEqualityComparer

Welcome to SO. What is TypeSymbolMetaType? Can you show more of your code? — Tim Schmelter
– Tim Schmelter, Commented Apr 26, 2023 at 15:09
What the error message suggests would be using public int GetHashCode([DisallowNull] TypeSymbolMetaType? obj) => SymbolEqualityComparer.Default.GetHashCode(obj.TypeSymbol);, as per docs with some rationale explained here. — orhtej2
– orhtej2, Commented Apr 26, 2023 at 15:16

Guru Stron · Accepted Answer · 2023-04-26 15:32:27Z

0

Assuming TypeSymbol is ISymbol then you don't need to use Combine in this example:

public int GetHashCode([DisallowNull] TypeSymbolMetaType? obj) => SymbolEqualityComparer.Default.GetHashCode(obj.TypeSymbol);

In case you want to combine multiple properties the use the result of the SymbolEqualityComparer.Default.GetHashCode:

public int GetHashCode([DisallowNull] TypeSymbolMetaType? obj) => 
        System.HashCode.Combine(
            SymbolEqualityComparer.Default.GetHashCode(obj.TypeSymbol).
            ...);

P.S.

In some cases you might need to use SymbolEqualityComparer.IncludeNullability.

answered Apr 26, 2023 at 15:32

Guru Stron

150k11 gold badges186 silver badges231 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to implement HashCode.Combine using SymbolEqualityComparer

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related